Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
SampleBuffer -> Samplerate - Fix two sample rate issues: #4991
#4786 is not fixed with this PR.
I guess, the sample on the sample track is played with its own samplerate. I exported a clicktrack (with 44100) and loaded it to the sample track. My Jack runs with 48000 Hz. The click and the sample aren't in sync anymore.
Ok, I've found the right commit. However, I can't understand how your solution has solved it? :\
2 times, most recently
May 28, 2019
Thanks! I'll look into that in a few hours.…
On Wed, 29 May 2019, 11:47 Steffen Baranowsky, ***@***.***> wrote: *@BaraMGB* commented on this pull request. ------------------------------ In src/core/SampleBuffer.cpp <#4991 (comment)>: > @@ -1196,7 +1201,7 @@ SampleBuffer * SampleBuffer::resample( const sample_rate_t _src_sr, src_data.data_out = dst_buf; src_data.input_frames = frames; src_data.output_frames = dst_frames; - src_data.src_ratio = (double) _dst_sr / _src_sr; + src_data.src_ratio = (double) _src_sr / _dst_sr; My Jack is running on 48Khz. I have a click track. I export the project *.wav with 44,1 khz. I insert the *.wav to a sample track. It isn't in sync: [image: Bildschirmfoto von 2019-05-29 10-37-38] <https://user-images.githubusercontent.com/6502580/58543012-dc58e380-81fe-11e9-9c4f-fee53f266c06.png> If I revert this line (_dst_sr / _src_sr) it is in sync: [image: Bildschirmfoto von 2019-05-29 10-39-19] <https://user-images.githubusercontent.com/6502580/58543102-08746480-81ff-11e9-9fee-e08991831025.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4991?email_source=notifications&email_token=AFOMGKCRTHMBXKI5NG4IKNTPXY7J7A5CNFSM4HPVG4AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZ63ARQ#pullrequestreview-243118150>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFOMGKFLPCHJROEUMPSEOWDPXY7J7ANCNFSM4HPVG4AA> .