Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated splash screen #5002

Merged
merged 1 commit into from Jun 7, 2019

Conversation

Projects
None yet
3 participants
@RebeccaDeField
Copy link
Contributor

commented Jun 3, 2019

Updated the splash screen to match the current logo/branding/website that @Umcaruje worked on.

Old
splash

New
splash

It's been a while since I've used git or github so if I've done this incorrectly just let me know. I removed the alpha layer but the splash still needs to be reviewed to make sure we don't encounter the same issue here #4062.

@PhysSong

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

I confirmed that the image doesn't have an alpha channel. 👍

@RebeccaDeField

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

@PhysSong So is this good to merge, then?

@PhysSong

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

I can't comment on the design itself, so I think it's fine to merge if you think it's okay.

@RebeccaDeField RebeccaDeField merged commit d194c70 into LMMS:stable-1.2 Jun 7, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
@zonkmachine

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

With this splash.png I get libpng warning: iCCP: CRC error on startup.
I'm on LinuxMint/libpng12.

@PhysSong

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Same here with Ubuntu 18.04/libpng16.

@zonkmachine

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

$ pngcheck ../data/themes/default/splash.png
../data/themes/default/splash.png CRC error in chunk iCCP (computed a0032057, expected a4b05ab4)

@PhysSong

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Possibly related: https://gitlab.gnome.org/GNOME/gimp/issues/2111
If I manually change the checksum in the image file using hex editor, the bug is gone.
Here's the image file with the checksum fixed:
splash
I can commit the change now.

@PhysSong

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

@RebeccaDeField If you used GIMP to export this image, could you try unchecking Save Color Profile on export?

@RebeccaDeField

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

@PhysSong Yes. Is there a way for you to test this against the file you produced to make sure this is solving the problem?

splash

@PhysSong

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

@PhysSong Yes. Is there a way for you to test this against the file you produced to make sure this is solving the problem?

I checked this file with both pngcheck and GIMP, and it looks fine. The error message is also gone. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.