Rubberband fix for selecting large area in Songeditor#5003
Conversation
If you want to test more, we can include this in 1.2.1 instead of 1.2.0. |
PhysSong
left a comment
There was a problem hiding this comment.
This is the first part of my review. I will review this PR again in a few days.
|
Thank you for your time. |
PhysSong
left a comment
There was a problem hiding this comment.
Here are minor comments regarding whitespaces. I'm testing the functionality and will let you know if there are any issues or not.
|
I found that lassoing with Shift+drag on the timeline is broken. @BaraMGB Could you look into it? |
|
@PhysSong Thank you. I'll look into it. 👍 |
|
@PhysSong can this be merged or do you want to test it more? |
|
The functionality looks okay, but I think we have some time to test this more because this PR targets the stable branch. |
|
@PhysSong Do you think, this should go into 1.2.1? |
|
I think it's okay to merge this now. As far as I tested, this won't bring any serious regressions. |
fixes #4974
scrolling and zooming while selecting an area works now. But with 180 additions and 70 deletions this is a big bug fix. I don't know if this should be merged so close before releasing 1.2.