Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Mixer fader falloff speed #5038

Merged
merged 5 commits into from Jun 22, 2019
Merged

Increase Mixer fader falloff speed #5038

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a2b123e
Merge pull request #2 from LMMS/master
LostRobotMusic Jan 3, 2019
6b23e64
Merge pull request #3 from LMMS/master
LostRobotMusic Mar 9, 2019
271e20d
Merge pull request #4 from LMMS/master
LostRobotMusic Apr 14, 2019
d683a51
Merge pull request #7 from LMMS/master
LostRobotMusic May 31, 2019
499d425
Increase Mixer fader falloff speed
LostRobotMusic Jun 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/gui/FxMixerView.cpp
View file
Open in desktop
Expand Up @@ -599,23 +599,25 @@ void FxMixerView::updateFaders()
{
const float opl = m_fxChannelViews[i]->m_fader->getPeak_L();
const float opr = m_fxChannelViews[i]->m_fader->getPeak_R();
const float fallOff = 1.07;
if( m->effectChannel(i)->m_peakLeft > opl )
const float fallOff = 1.25;
if( m->effectChannel(i)->m_peakLeft >= opl/fallOff )
{
m_fxChannelViews[i]->m_fader->setPeak_L( m->effectChannel(i)->m_peakLeft );
m->effectChannel(i)->m_peakLeft = 0;
// Set to -1 so later we'll know if this value has been refreshed yet.
m->effectChannel(i)->m_peakLeft = -1;
}
else
else if( m->effectChannel(i)->m_peakLeft != -1 )
{
m_fxChannelViews[i]->m_fader->setPeak_L( opl/fallOff );
}

if( m->effectChannel(i)->m_peakRight > opr )
if( m->effectChannel(i)->m_peakRight >= opr/fallOff )
{
m_fxChannelViews[i]->m_fader->setPeak_R( m->effectChannel(i)->m_peakRight );
m->effectChannel(i)->m_peakRight = 0;
// Set to -1 so later we'll know if this value has been refreshed yet.
m->effectChannel(i)->m_peakRight = -1;
}
else
else if( m->effectChannel(i)->m_peakRight != -1 )
{
m_fxChannelViews[i]->m_fader->setPeak_R( opr/fallOff );
}
Expand Down