Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show BBEditor on clicking the TrackLabelButton #5060

Merged
merged 1 commit into from Jul 26, 2019

Conversation

@BaraMGB
Copy link
Contributor

@BaraMGB BaraMGB commented Jun 27, 2019

In the LMMS.io forums a user reported the following:

I have an issue in new stable release 1.2.0

When you close the beat+bass line editor screen, and if you click to open it again, the beat+bass line editor screen don't open, you have to press the shortcut to open it again.

I have tried in another PC and it's the same.
In LMMS 1.2.0 RC8 the behavior is normal and open and close as always.

The user means the TrackLabelButton. This PR fixes the issue.

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Jun 29, 2019

I guess it's introduced in #1426, and the change in this fix is consitent with the PR.

@BaraMGB
Copy link
Contributor Author

@BaraMGB BaraMGB commented Jun 29, 2019

Do you think, we shouldn't fix it in stable? @PhysSong

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Jun 29, 2019

Yes, it's a regression in 1.2.

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Jul 26, 2019

Merge?

@BaraMGB BaraMGB merged commit bdbea87 into LMMS:stable-1.2 Jul 26, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants