Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed renaming mixer channel from the context menu #5083

merged 1 commit into from Jul 20, 2019


Copy link

@v0idzz v0idzz commented Jul 20, 2019

renameChannel() wasn't a slot previously, so the menu couldn't access it. This PR fixes that.

Copy link

Nice catch. Tested it, everything's good. I'll go ahead and merge it now.

@LostRobotMusic LostRobotMusic merged commit d949770 into LMMS:master Jul 20, 2019
@v0idzz v0idzz deleted the fix/context-menu-channel-rename branch July 21, 2019 10:19
Copy link

@Sawuare Sawuare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think renameChannel() should be a private slot, like renameFinished().

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022

Fixed renaming mixer channel from the context menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants