Fix for the SF2 with no "default" patch#5084
Merged
Merged
Conversation
PhysSong
reviewed
Jul 31, 2019
PhysSong
left a comment
PhysSong
left a comment
Member
There was a problem hiding this comment.
Thank you for your work, and sorry for the late response.
Here are some feedbacks.
Contributor
Author
|
Hey @PhysSong, |
Contributor
I think it's Homebrew acting up a bit. Restarting the Mac build a couple of times worked. |
Contributor
Author
|
Sounds good, I would have thought that since Mac OS was POSIX compliant that it would have just been compatible but hombrew tool is something else. |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the instructions from #323 to test the fix for this PR, I was able to reproduce the problem and provide a fix. Let me know if there is anything else that is left from the issue.