Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow playing muted pattern in the piano roll #5134

merged 2 commits into from Aug 21, 2019


Copy link

@Veratil Veratil commented Aug 19, 2019

An annoyance to me so far has been wanting to listen to a pattern I just opened from the Song Editor, but I've muted it beforehand for whatever reason. I am then required to click back to the Song Editor to unmute the pattern (I don't know if there's a shortcut key to unmute the pattern from the Piano Roll window) and then I can go back to the Piano Roll to listen to it.

This should allow the Piano Roll (and I believe any other editor which uses InstrumentTrack) to play its pattern while being muted on the Song Editor.

My next step I want to be able to do is play while the entire track is muted, since this PR doesn't fix that instance.

src/tracks/InstrumentTrack.cpp Outdated Show resolved Hide resolved
Copy link

Spekular commented Aug 19, 2019 via email

Copy link
Contributor Author

Veratil commented Aug 19, 2019

I think PhysSong means that tracks muted inside the bb editor will still play, which is obviously undesireable. Otherwise you could have a kick/snare loop you're previewing in the BB editor, mute the snare track, and have the snare continue to play.

Ah! That's right. I just tested and that does indeed ignore the mute in BB Editor. Will fix. 👍

@PhysSong PhysSong changed the title Allow PianoRoll to play while muted Allow playing muted pattern in the piano roll Aug 21, 2019
@PhysSong PhysSong merged commit c80519e into LMMS:master Aug 21, 2019
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants