Repository navigation
Allow playing muted pattern in the piano roll - #5134
Merged
Merged
Conversation
PhysSong
reviewed
Aug 19, 2019
Member
|
I think PhysSong means that tracks muted *inside the bb editor* will still
play, which is obviously undesireable.
Otherwise you could have a kick/snare loop you're previewing in the BB
editor, mute the snare track, and have the snare continue to play.
|
Contributor
Author
Ah! That's right. I just tested and that does indeed ignore the mute in BB Editor. Will fix. 👍 |
PhysSong
approved these changes
Aug 21, 2019
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An annoyance to me so far has been wanting to listen to a pattern I just opened from the Song Editor, but I've muted it beforehand for whatever reason. I am then required to click back to the Song Editor to unmute the pattern (I don't know if there's a shortcut key to unmute the pattern from the Piano Roll window) and then I can go back to the Piano Roll to listen to it.
This should allow the Piano Roll (and I believe any other editor which uses
InstrumentTrack) to play its pattern while being muted on the Song Editor.My next step I want to be able to do is play while the entire track is muted, since this PR doesn't fix that instance.