Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4188 - Check for failed std::find #5137

Merged
merged 1 commit into from Sep 14, 2019
Merged

Conversation

Veratil
Copy link
Contributor

@Veratil Veratil commented Aug 21, 2019

I noticed this crashed on stable-1.2 and then in master.

Crash happens when trying to erase a note that doesn't exist in m_markedSemiTones when selecting "Mark/unmark all corresponding octave semitones", so the solution is just to check for a failed std::find.

@Reflexe
Copy link
Member

Reflexe commented Aug 23, 2019

@PhysSong I'm not sure, Do we have to target it for stable and sync it later to master? Or just do it manually now?

@Reflexe Reflexe self-assigned this Aug 23, 2019
@PhysSong
Copy link
Member

@Reflexe Since #4188 is in the 1.2.1 milestone, the commit should somehow go to stable-1.2. The specific method doesn't matter too much, but I think it'd be better to merge into stable-1.2 first.
This should be tested before we merge this, of course.

@Reflexe Reflexe added the needs testing This pull request needs more testing label Aug 23, 2019
@Reflexe Reflexe added this to the 1.2.1 milestone Sep 14, 2019
@Reflexe Reflexe changed the base branch from master to stable-1.2 September 14, 2019 16:59
@Reflexe Reflexe changed the base branch from stable-1.2 to master September 14, 2019 16:59
@Reflexe Reflexe modified the milestones: 1.2.1, 1.3.0 Sep 14, 2019
@Reflexe
Copy link
Member

Reflexe commented Sep 14, 2019

Since we've changed qFind to std::find between stable-2 and master, I;ve created another pr for stable: #5184

@Reflexe Reflexe merged commit 8fdf6c4 into LMMS:master Sep 14, 2019
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing This pull request needs more testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants