Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make splash screen text white, themeable #5149

Merged
merged 4 commits into from Aug 27, 2019
Merged

Make splash screen text white, themeable #5149

merged 4 commits into from Aug 27, 2019

Conversation

@Spekular
Copy link
Contributor

@Spekular Spekular commented Aug 25, 2019

Closes #5023

Copy link
Contributor Author

@Spekular Spekular left a comment

Themeable solution, part 1.

src/gui/GuiApplication.cpp Outdated Show resolved Hide resolved
src/gui/GuiApplication.cpp Outdated Show resolved Hide resolved
@Spekular Spekular changed the title Make splash screen text white Make splash screen text white, themeable Aug 25, 2019
@Spekular
Copy link
Contributor Author

@Spekular Spekular commented Aug 25, 2019

This should probably be squashed into one commit if/when merged.

@tresf
Copy link
Member

@tresf tresf commented Aug 26, 2019

@Spekular I recommend doing it without code changes if possible...

QSplashScreen QLabel {
	color: white;
}

@Spekular
Copy link
Contributor Author

@Spekular Spekular commented Aug 27, 2019

Huh. GuiApplication QLabel { //stuff } seemed to either do nothing or break the theme (I don't recall which, I tried a few different things) so I figured that kinda thing wouldn't work.

Will fix.

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Aug 27, 2019

I tested @tresf's solution locally. It seems to work.

Copy link
Contributor Author

@Spekular Spekular left a comment

@tresf 's suggestions

data/themes/default/style.css Outdated Show resolved Hide resolved
data/themes/default/style.css Outdated Show resolved Hide resolved
data/themes/default/style.css Show resolved Hide resolved
src/gui/GuiApplication.cpp Outdated Show resolved Hide resolved
src/gui/GuiApplication.cpp Outdated Show resolved Hide resolved
@tresf tresf merged commit 8568ae4 into LMMS:stable-1.2 Aug 27, 2019
2 checks passed
@Spekular Spekular deleted the patch-5 branch Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants