Skip to content

Make splash screen text white, themeable - #5149

Merged
tresf merged 4 commits into
LMMS:stable-1.2from
Spekular:patch-5
Aug 27, 2019
Merged

tresf merged 4 commits into
LMMS:stable-1.2from
Spekular:patch-5

Conversation

@Spekular

Copy link
Copy Markdown
Member

Closes #5023

@Spekular Spekular left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Themeable solution, part 1.

Comment thread src/gui/GuiApplication.cpp Outdated
Comment thread src/gui/GuiApplication.cpp Outdated
@Spekular Spekular changed the title Make splash screen text white Make splash screen text white, themeable Aug 25, 2019
@Spekular

Copy link
Copy Markdown
Member Author

This should probably be squashed into one commit if/when merged.

@tresf

tresf commented Aug 26, 2019

Copy link
Copy Markdown
Member

@Spekular I recommend doing it without code changes if possible...

QSplashScreen QLabel {
	color: white;
}

@Spekular

Copy link
Copy Markdown
Member Author

Huh. GuiApplication QLabel { //stuff } seemed to either do nothing or break the theme (I don't recall which, I tried a few different things) so I figured that kinda thing wouldn't work.

Will fix.

@PhysSong

Copy link
Copy Markdown
Member

I tested @tresf's solution locally. It seems to work.

@Spekular Spekular left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tresf 's suggestions

Comment thread data/themes/default/style.css Outdated
Comment thread data/themes/default/style.css Outdated
Comment thread data/themes/default/style.css
Comment thread src/gui/GuiApplication.cpp Outdated
Comment thread src/gui/GuiApplication.cpp Outdated
@tresf
tresf merged commit 8568ae4 into LMMS:stable-1.2 Aug 27, 2019
@Spekular
Spekular deleted the patch-5 branch August 10, 2020 15:24
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Make splash screen text white
Closes LMMS#5023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants