Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent LMMS VisualizationWidget from showing clipping color at exactly 0 db #5162

Merged
merged 4 commits into from Aug 30, 2019

Conversation

LostRobotMusic
Copy link
Contributor

So... I know this looks really dumb and unnecessary, and is probably the most basic PR ever made in the history of mankind, but this is a bugfix.

It's very common for me to be playing a sound that hits exactly 0 db (but doesn't cross 0 db), and when I see the visualizer turn red, I think the sound is clipping. This is especially common when playing an individual sound with lots of distortion applied (many/most types of distortion have a hard limit at exactly 0 db). This PR just changes "<" to "<=" in the code, which is how it should be.

I... feel embarrassed, like I'm breaking a serious rule for making a PR that's so basic. 馃槅
I'm assuming this can just be merged instantly (well, squash-and-merged, sorry for messy commit history), though I will verify on Discord first.

@LostRobotMusic LostRobotMusic changed the title Prevent LMMS VisualizationWidget from turning red at exactly 0 db Prevent LMMS VisualizationWidget from showing clipping color at exactly 0 db Aug 30, 2019
@LostRobotMusic LostRobotMusic merged commit c2eefe7 into LMMS:master Aug 30, 2019
@LostRobotMusic LostRobotMusic deleted the visualizer-clipping-fix branch August 30, 2019 23:08
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant