Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MIDI connections from factory .mmpz files #5163

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Sep 1, 2019

In #4207, I missed .mmpz files as I couldn't grep them directly. MIDI connections in those files may affect other project files due to #3790.

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Sep 7, 2019

Great! It's a bit of a hazzle to compare the files as it's compressed stuff. Maybe the project files should be in .mmp format in the source and then compressed when building?

Anyway, here's an example of the issue/fix. In shorties/DirtyLove.mmpz open the FXMixer and right click the master mute. It is connected to a MIDI channel.

--- /home/zonkmachine/lmms/projects/bugs/dirtymidiorig.mmp
+++ /home/zonkmachine/lmms/projects/bugs/dirtymidi.mmp
@@ -1944,11 +1944,6 @@
             </key>
           </effect>
         </fxchain>
-        <connection>
-          <muted>
-            <Midicontroller outputchannel="1" outputcontroller="0" basevelocity="127" name="MIDI ch1 ctrl37" outputprogram="1" fixedinputvelocity="-1" fixedoutputvelocity="-1" fixedoutputnote="-1" inputchannel="1" inputcontroller="37" inports="" readable="1" type="2" writable="0"/>
-          </muted>
-        </connection>
       </fxchannel>
       <fxchannel muted="0" num="1" name="Beat" volume="0.56" soloed="0">
         <fxchain enabled="1" numofeffects="3">

I think this can be merged.

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Sep 12, 2019

Merge?

@PhysSong PhysSong merged commit c436e5c into LMMS:stable-1.2 Sep 12, 2019
1 check passed
@PhysSong PhysSong deleted the nommpzmidiconn branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants