Skip to content

Remove "What's This?" leftovers - #5173

Merged
husamalhomsi merged 4 commits into
LMMS:masterfrom
husamalhomsi:master
Sep 9, 2019
Merged

Remove "What's This?" leftovers#5173
husamalhomsi merged 4 commits into
LMMS:masterfrom
husamalhomsi:master

Conversation

@husamalhomsi

Copy link
Copy Markdown
Member

A follow-up to #4128.

@husamalhomsi

Copy link
Copy Markdown
Member Author

I got excited when I saw whatsthis.png and removed them thoughtlessly, turns out they are used somewhere. 😅

@husamalhomsi

Copy link
Copy Markdown
Member Author

I believe this is it and there is nothing left.

@PhysSong

PhysSong commented Sep 7, 2019

Copy link
Copy Markdown
Member

I got excited when I saw whatsthis.png and removed them thoughtlessly, turns out they are used somewhere. 😅

It's here:

lmms/src/core/DataFile.cpp

Lines 1498 to 1510 in 84d1091

TextFloat::displayMessage(
SongEditor::tr( "Version difference" ),
SongEditor::tr(
"This %1 was created with "
"LMMS %2."
).arg(
_sourceFile.endsWith( ".mpt" ) ?
SongEditor::tr( "template" ) :
SongEditor::tr( "project" )
)
.arg( root.attribute( "creatorversion" ) ),
embed::getIconPixmap( "whatsthis", 24, 24 ),
2500

We may rename it instead if needed.

@husamalhomsi

Copy link
Copy Markdown
Member Author

We may rename it instead if needed.

I think it's fine as-is. Let it be a vestige of the extinct feature. 😄

@husamalhomsi

Copy link
Copy Markdown
Member Author

Merge?

@husamalhomsi
husamalhomsi merged commit a0e7a88 into LMMS:master Sep 9, 2019
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants