Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation Fixes (Continuation of #4482) #5185

Merged
merged 4 commits into from
Oct 10, 2019
Merged

Translation Fixes (Continuation of #4482) #5185

merged 4 commits into from
Oct 10, 2019

Conversation

zonkmachine
Copy link
Member

Fixes #5032

Fixing some formatting issues in LMMS-1.2 caused by translations.
Continuation of #4482

Problematic translation strings replaced with <translation type="unfinished"/> as mentioned here except for the polish translation where I removed one of the words. I don't speak polish. Not a bit.

@zonkmachine zonkmachine added the needs code review A functional code review is currently required for this PR label Sep 14, 2019
liushuyu
liushuyu reviewed Sep 14, 2019
View reviewed changes
Copy link
Member

@liushuyu liushuyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is leftover from #4482. I can fix it by going over the translations again and just removing the borked lines but maybe this is best handled on Transifex?

Yes, these changes will be eventually got overridden by Transifex. However, removing translations is not a decent way to do this since you will always find some languages got extra long strings somewhere.

@liushuyu liushuyu changed the title Translationfixes2 Translation Fixes (Continuation of #4482) Sep 14, 2019
@zonkmachine
Copy link
Member Author

zonkmachine commented Sep 14, 2019 •
edited
Loading

However, removing translations is not a decent way to do this since you will always find some languages got extra long strings somewhere.

What is the way to go about this then? Report the problematic lines on Transifex instead?
I won't have time to dive into that site. I tried once and we didn't seem to be compatible...
Do we merge back translations from Transifex for lmms-1.2 ?

@qnebra
Copy link

qnebra commented Sep 14, 2019

For me @liushuyu it was some kind of lazy translation. Translate without caring about avalaible space and line lenght.

@zonkmachine
Copy link
Member Author

Yes, these changes will be eventually got overridden by Transifex. However, removing translations is not a decent way to do this since you will always find some languages got extra long strings somewhere.

@liushuyu I don't get this. Should this PR be closed?
I don't have time to read up on how Transifex works unfortunately. Even if they will be removed later by transifex it will fix the formatting issues in lmms-1.2.1 that is currently being prepared. Should these strings be reported on Transifex each one separately and then fixed by the translators?

@liushuyu
Copy link
Member

Even if they will be removed later by transifex it will fix the formatting issues in lmms-1.2.1 that is being prepared.

You can merge this for now.

Should these strings be reported on Transifex each one separately and then fixed by the translators?

You can open an issue on Transifex.

@zonkmachine
Copy link
Member Author

You can open an issue on Transifex.

OK. Is this one issue per string? I don't find a general issue tracker there.

@liushuyu
Copy link
Member

liushuyu commented Oct 10, 2019 •
edited
Loading

Is this one issue per string?

Yes

I don't find a general issue tracker there.

There's a per-language tracker (discussion section). This is where Transifex does not work well.

@zonkmachine
Copy link
Member Author

zonkmachine commented Oct 10, 2019 •
edited
Loading

@liushuyu I have fixed the Swedish strings on transifex but for the rest I don't think I have access to even comment on the other languages (and I probably shouldn't have... :) )
I have found the LMMS translation team 'discussions page' however and will start a conversation there. Thanks for your patience!

@zonkmachine zonkmachine merged commit e321dff into LMMS:stable-1.2 Oct 10, 2019
@zonkmachine
Copy link
Member Author

zonkmachine commented Oct 10, 2019 •
edited
Loading

I have found the LMMS translation team 'discussions page' however and will start a conversation there.

https://www.transifex.com/lmms/teams/61632/discussions/19385/
Links, Pics and editing the post doesn't seem to work though.

@zonkmachine zonkmachine deleted the translationfixes2 branch October 10, 2019 18:14
@zonkmachine zonkmachine mentioned this pull request Oct 10, 2019
Closed
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
@zonkmachine
Translation Fixes (Continuation of LMMS#4482) (LMMS#5185)
ac4d14a 
Fix some formatting issues with some translations. 

* Russian
* Polish
* Swedish
* Ukrainian
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liushuyu liushuyu liushuyu left review comments

Assignees
No one assigned
Labels
needs code review A functional code review is currently required for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zonkmachine @qnebra @liushuyu