Remove global automation from MidiImport

[Veratil]

Completes step 1 from #403

[LmmsBot]

Downloads for this pull request

• Windows 32 Bit: download.
• Windows 32 Bit: download.
• Windows 64 Bit: download.
• Windows 64 Bit: download.

Generated by the LMMS pull requests bot.
SHA: ff93d48

[PhysSong]

The rest of this PR looks fine.

[Reflexe]

This PR is broken with VS builds. see https://ci.appveyor.com/project/Lukas-W/lmms/builds/28005325/job/1d524yxraw2rrw5q

MidiImport.obj : error LNK2001: unresolved external symbol "public: virtual void __thiscall TrackContentObject::movePosition(class MidiTime const &)" (?movePosition@TrackContentObject@@UAEXABVMidiTime@@@Z) [C:\projects\lmms\build\plugins\MidiImport\midiimport.vcxproj]
MidiImport.obj : error LNK2001: unresolved external symbol "public: virtual void __thiscall TrackContentObject::changeLength(class MidiTime const &)" (?changeLength@TrackContentObject@@UAEXABVMidiTime@@@Z) [C:\projects\lmms\build\plugins\MidiImport\midiimport.vcxproj]
C:\projects\lmms\build\plugins\Debug\midiimport.dll : fatal error LNK1120: 2 unresolved externals 

[Veratil]

This PR is broken with VS builds. see https://ci.appveyor.com/project/Lukas-W/lmms/builds/28005325/job/1d524yxraw2rrw5q

MidiImport.obj : error LNK2001: unresolved external symbol "public: virtual void __thiscall TrackContentObject::movePosition(class MidiTime const &)" (?movePosition@TrackContentObject@@UAEXABVMidiTime@@@Z) [C:\projects\lmms\build\plugins\MidiImport\midiimport.vcxproj]
MidiImport.obj : error LNK2001: unresolved external symbol "public: virtual void __thiscall TrackContentObject::changeLength(class MidiTime const &)" (?changeLength@TrackContentObject@@UAEXABVMidiTime@@@Z) [C:\projects\lmms\build\plugins\MidiImport\midiimport.vcxproj]
C:\projects\lmms\build\plugins\Debug\midiimport.dll : fatal error LNK1120: 2 unresolved externals 

I don't see how this PR would affect that, I didn't touch those functions.

[PhysSong]

I'm not sure why MinGW builds pass while MSVC builds fail, but I found the reason: class TrackContentObject is not marked as exported. Changing class TrackContentObject to class LMMS_EXPORT TrackContentObject in Track.h will fix this.

[PhysSong]

I found that MIDI import still uses global automation because Song::tempoAutomationPattern() uses it.

[Veratil]

I found that MIDI import still uses global automation because Song::tempoAutomationPattern() uses it.

There's also a few calls to AutomationPattern::globalAutomationPattern which in turn calls Engine::getSong()->globalAutomationTrack(). The hole gets deeper. 🤔

[PhysSong]

There's also a few calls to AutomationPattern::globalAutomationPattern which in turn calls Engine::getSong()->globalAutomationTrack().

True, but after removing Song::tempoAutomationPattern and its usage, new global automation patterns can be created only by manual GUI actions.