Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piano Roll - Fix retrigger with vol/pan sliders #5271

Merged
merged 1 commit into from Oct 29, 2019

Conversation

zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Oct 23, 2019

Fixes LMMS/lmms/#3637 where notes are retriggered when moving vol/pan sliders of a partially selected chord and it has an envelope.

@zonkmachine
Copy link
Member Author

zonkmachine commented Oct 27, 2019

This is now ready and I'll merge in a couple of days.

@zonkmachine zonkmachine merged commit 6c865c0 into LMMS:stable-1.2 Oct 29, 2019
@zonkmachine
Copy link
Member Author

zonkmachine commented Oct 29, 2019

Fixes LMMS/lmms/#3637

Nope. I was wrong about auto-closing statements in non base branches.

@zonkmachine zonkmachine deleted the fixpreviewretrig branch Oct 29, 2019
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant