Fix scrolling direction in SongEditor due to stuck Ctrl/Shift. - #5286
Conversation
|
|
36bc837 to
4daf642
Compare
|
A bit more info please: What is the issue you are fixing? What are the steps to reproduce that issue? |
|
Not required but it will help future readers if you split stuff into multiple commits, e.g. cleanups, override fixes, ... It's not difficult, just a |
|
It fixes that if scrolling with the mouse wheel in the Song Editor, it would often unexpectedly zoom or scroll horizontally instead of scrolling vertically, due to a stuck Ctrl/Shift state. This was reproducible by switching away from LMMS using Ctrl+F[1-10] to change desktops, and switching back again without using Ctrl. Then LMMS would behave as if the Ctrl key was still down. Not sure how to reproduce Shift being stuck down, but it also happened sometimes somehow. As a side effect, it should also fix a theoretical issue of it thinking Ctrl/Shift was down during the click when it was actually pressed after the click (might happen in the case of very slow computers). |
JohannesLorenz
left a comment
There was a problem hiding this comment.
Testing worked. Code and style are OK. Only left 1 comment about .gitignore.
|
I also tested the ctrl key issue, it's working. No regressions for shift and ctrl. Testing finished. |
4daf642 to
f96b544
Compare
|
Thanks! |
|
FYI, I'm getting a deprecation warning since |
|
I removed |
As far as I can tell, MainWindow::focusOutEvent never gets called no matter what I do, so clearKeyModifiers fails to be called.