Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with the AppImage launcher script #5297

Merged
merged 3 commits into from Nov 1, 2019

Conversation

Reflexe
Copy link
Member

@Reflexe Reflexe commented Nov 1, 2019

Fixes #5284

@Reflexe
Copy link
Member Author

@Reflexe Reflexe commented Nov 1, 2019

I will wait for circleci to pass and then rebase it for stable.

cmake/linux/package_linux.sh.in Outdated Show resolved Hide resolved
@LmmsBot
Copy link

@LmmsBot LmmsBot commented Nov 1, 2019

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"commit_sha": "816d81f69f3854e41489f66a7dd8a1c20a182566", "platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://1173-143851518-gh.circle-artifacts.com/0/lmms-1.2.0-rc6.753-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/Reflexe/lmms/1173?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://1176-143851518-gh.circle-artifacts.com/0/lmms-1.2.0-rc6.753-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/Reflexe/lmms/1176?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://1174-143851518-gh.circle-artifacts.com/0/lmms-1.2.0-rc6.753-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/Reflexe/lmms/1174?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://1177-143851518-gh.circle-artifacts.com/0/lmms-1.2.0-rc6.753-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/Reflexe/lmms/1177?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}}

@Reflexe Reflexe force-pushed the fix_appimage_wordsplitting branch from bebf1dd to 816d81f Compare Nov 1, 2019
@Reflexe
Copy link
Member Author

@Reflexe Reflexe commented Nov 1, 2019

Tested it, working great.

> mkdir "Directory With Spaces"
> mv ~/Downloads/lmms-1.2.0-rc6.753-linux-x86_64.AppImage Directory\ With\ Spaces/
> Directory\ With\ Spaces/lmms-1.2.0-rc6.753-linux-x86_64.AppImage

> cd Directory\ With\ Spaces
> ./lmms-1.2.0-rc6.753-linux-x86_64.AppImage

> ./lmms-1.2.0-rc6.753-linux-x86_64.AppImage --appimage-extract
> cd squashfs-root 
> ./AppRun 

@Reflexe Reflexe force-pushed the fix_appimage_wordsplitting branch from 816d81f to 40f8334 Compare Nov 1, 2019
@Reflexe Reflexe changed the base branch from master to stable-1.2 Nov 1, 2019
@PhysSong PhysSong changed the title Fix appimage launcher shellcheck Fix some issues with the AppImage launcher script Nov 1, 2019
@Reflexe Reflexe merged commit 08c7e8e into LMMS:stable-1.2 Nov 1, 2019
1 of 2 checks passed
@Reflexe Reflexe deleted the fix_appimage_wordsplitting branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants