Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3183: Fix file factory delimeter position #5378

Merged
merged 2 commits into from
Jan 22, 2020

Conversation

JohannesLorenz
Copy link
Contributor

Testers

@karmux @zonkmachine Can you please both test this branch (just open LMMS and check some of the delimeters in the file browsers)? With the help of two testers, more file hierarchies are tested.

Code review

Volunteers? ☠️ 😄

@JohannesLorenz JohannesLorenz added needs style review A style review is currently required for this PR needs code review A functional code review is currently required for this PR needs testing This pull request needs more testing labels Jan 19, 2020
@JohannesLorenz JohannesLorenz added this to the 1.2.2 milestone Jan 19, 2020
@zonkmachine zonkmachine self-requested a review January 19, 2020 20:13
@zonkmachine
Copy link
Member

Thank you so much for commenting the code! 🍰
I'm testing away and it passes everything I've been throwing at it so far.

@karmux
Copy link
Contributor

karmux commented Jan 20, 2020

Separators always appear at expected places in this branch 👍

@JohannesLorenz
Copy link
Contributor Author

Many thanks you two for testing. Only code-review is left now.

@JohannesLorenz JohannesLorenz removed the needs testing This pull request needs more testing label Jan 20, 2020
@zonkmachine
Copy link
Member

I'm starting to grasp the code a bit more now. This looks about right. Style looks fine too.

@JohannesLorenz JohannesLorenz removed needs code review A functional code review is currently required for this PR needs style review A style review is currently required for this PR labels Jan 22, 2020
@JohannesLorenz
Copy link
Contributor Author

Thanks for testing. I'm merging this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants