Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bias dropped clip position backwards #5401

merged 1 commit into from Apr 12, 2020


Copy link

This matches the drop behavior from before #4973, as users expect clips to start on the bar they hover over, not on the bar whose start is closer to the cursor. Scales with snap size as well, so it drops onto the half-bar hovered over rather than the half-bar whose start is closer to the cursor, etc.
Closes #5393

@Spekular Spekular added this to the 1.3.0 milestone Feb 23, 2020
Copy link

LmmsBot commented Feb 23, 2020

🤖 Hey, I'm @LmmsBot from and I made downloads for this pull request, click me to make them magically appear! 🎩



{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": ""}}, "build_link": ""}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": ""}}, "build_link": ""}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": ""}}, "build_link": ""}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": ""}}, "build_link": ""}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": ""}}, "build_link": ""}]}, "commit_sha": "bbb3624399e2683864e34c51f7d5f00968f25685"}

Copy link

The code looks good. Please feel free to merge it if you think we should revert to the old snapping behavior(no objections from me, FYI).

@Spekular Spekular merged commit 2419433 into LMMS:master Apr 12, 2020
Copy link
Contributor Author

Thanks for the review! :)

@Spekular Spekular deleted the dropPosition branch August 10, 2020 15:21
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Bias dropped clip position backwards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Loop drops onto next bar over (macOS Mojave 10.14, LMMS v1.2.1.581)
3 participants