Arpeggiator - Cut off trailing short notes

[zonkmachine]

Prevent triggering of extra notes at the end by not counting trailing notes shorter than one fifth of the notes arp_frames. This value being arbitrarily found by trial and error.

Addresses one of the tickets (Extra notes) in #3880
The picture in 3880 also demonstrates this fix in the lower stereo track where the duplicated notes (the bigger notes) are gone but the missing notes (another, separate issue) remains.

[LmmsBot]

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

• Linux (AppImage): lmms-1.2.1.685-linux-x86_64.AppImage (build link)

Windows

• Windows 32-bit: lmms-1.2.1.685-mingw-win32.exe (build link)
• Windows 64-bit: lmms-1.2.1.685-mingw-win64.exe (build link)
• Windows 32-bit: lmms-1.2.1-msvc2017-win32.exe (build link)
• Windows 64-bit: lmms-1.2.1-msvc2017-win64.exe (build link)

macOS

• macOS : lmms-1.2.1.685-mac10.13.dmg (build link)

🤖

{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://6747-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.685-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6747?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://6748-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.685-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6748?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://6746-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.685-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6746?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/ndq9cw0jd01tswh1/artifacts/build/lmms-1.2.1-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/33227569"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/hk5uig2ki8ngk7ub/artifacts/build/lmms-1.2.1-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/33227569"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://6745-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.685-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6745?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "1d56e3f29186778a55fb093466fbe595a3bc9c08"}

[tresf]

@zonkmachine this is a one-liner, is there a reason why it hasn't been merged?

[zonkmachine]

@tresf I've been busy at work. I'll have to look into this again.

[zonkmachine]

I think it's fine to merge but theoretically it could make your old project skip a note at the end if you have already tweaked the note length to avoid this issue but have set it to cut off precisely after the last arp note goes on. I think this will happen in precisely 0 cases but you never know. I don't know if there's a better way to do this than an arbitrary small number like this.

[zonkmachine]

I'll test it some more and then merge in a couple of days if there are no objection.