Modifying factory presets to sound more friendly.

[zynskeywolf]

fixes #5527.

• Added a very short attack and release to prevent click
• Adjusted some levels to prevent clipping
• Removed DC offset.

[LmmsBot]

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

• Linux (AppImage): lmms-1.2.3-733%2Bgbddddd6-linux-x86_64.AppImage (build link)

Windows

• Windows 32-bit: lmms-1.2.3-733%2Bgbddddd643-mingw-win32.exe (build link)
• Windows 64-bit: lmms-1.2.3-733%2Bgbddddd643-mingw-win64.exe (build link)
• Windows 32-bit: lmms-1.2.2-msvc2017-win32.exe (build link)
• Windows 64-bit: lmms-1.2.2-msvc2017-win64.exe (build link)

🤖

{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://9562-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-733%2Bgbddddd6-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9562?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://9563-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-733%2Bgbddddd643-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9563?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://9560-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-733%2Bgbddddd643-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9560?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/c5nu2jsqw8k5j5ie/artifacts/build/lmms-1.2.2-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35806189"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/k0pck8g3bw96co83/artifacts/build/lmms-1.2.2-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35806189"}]}, "commit_sha": "9b2ec7c7119136943dbb6244d2b17088d7f3e7b9"}

[qnebra]

For me, from what I tested, in terms of sound this is really nice. I know, this is subjective and without scientific scrutiny, but I think this made presets better.

[tresf]

Is this 1000 a typo?

[tresf]

fixes #5527

I'm not sure this statement is true. Think it partially fixes #5527. To that point, I'd like @musikBear to review this PR as the author of the linked bug report.

Furthemore, I'd love someone to go through these presets (all 40, before and after) and make sure they are in fact better than before. I think @qnebra has done this, but I'm not sure.

Preset changes are generally safe because they don't affect existing projects, only new ones. Perhaps to speed this up, @dj-pixus could create a zip file attachment with all affected presets. That way, a non-developer can jump in and help review. I'm also going to cross-post in #testing on Discord.

[superpaik]

Modified presets in a zip: presets-#5529.zip

Sound is subjective, but I found some issues if you wanna doublecheck:

• bitinvader - subbass, has less click at the beginning than the original but still (I think is due to the waveform)
• bitinvader - toypiano, too low volume around -30dB (also in the original)
• kicker - trapkick, still has a click, increasing attack to 0,02 will do
• organic - rubberband, to much volume (also in the original) it clips
• SID - bass, the AMT is not activated, so the enveloped is not working. If activated, the sound is weird for a bass, maybe a increase the HOLD and shorten the SUST.
• TripleOsc - RaveBass, still has click, maybe double the attack.
• TripleOsc - Space Bass, totally different sound. Maybe is due to the 'userwavefile0="samples/empty.wav"' param, I don't find it
• TripleOsc - Square, also different sound. The same reason ¿?
• TripleOsc - TranceLead, attack=0 ¿?
• Xpressive - can't test because I don't have it installed (windows lmms-v1.2.2)

[zynskeywolf]

Made some fine tuning on the presets @superpaik mentioned, and also some new ones. And corrected the 1000% typo.
However, there are cases where the "problems" are intended, e.g. some Kicker presets have the Click knob turned up, because that's part of the concept. So I left them in peace.
Also there were some hyper-super stereo effects with serious phase problems, tried to regulate them a bit.
In BitInvader preset Subbass there was an audio file loaded in the cutoff frequency LFO, no clue why. I removed it because it does not do anything good in any way.

[superpaik]

To me is ok! In anycase, presets are a starting point to get the sound the user wants, so is ok if some of them are not "perfect" because they have to be tailored by the user to the song/sound produced.

[tresf]

To me is ok! In anycase, presets are a starting point to get the sound the user wants, so is ok if some of them are not "perfect" because they have to be tailored by the user to the song/sound produced.

Thanks kindly for the review, it's greatly appreciated. @dj-pixus thanks for the contribution, we couldn't do this without the help of people like you!

These changes will only apply to new projects created with master from this point forward. Old projects will remain unmodified. I assume any preset-specific disagreements can be fixed on a new PR/issue.

Merging.

[musikBear]

Sorry i have not been active here for some days. I never saw
#5529 (comment)
I will look at the release.

[musikBear]

I have listened to those in the zipPack.
All are not to my personal preferences, but thats beside the scope. Clicks and Clipping has bee dealt with, and thats fine.
However there are many more -All samples should have envelopes. It would also remove a really stupid coding-issue with AFP, if all samples had saved sample-specific envelopes
That task is on the other hand a unrewarding task, because there is work being done on a brand new Sample-collection for lmms. However the old ones are still in use in all projects.
drtl...
Back on review
These i did not like -Otherwise good job @dj-pixus 👍

BitInvader
Bell:                         Should ring out
Toy-piano:                    Cant play two fast notes without blend. REL too long
wah_synth:                    A bit of LFO should be added to show full pentential

Organic
Rubberband:                   Not organ envelope and too loud

3oc
RaveBass:                     Better before. Filter not invoked
Space Bass:                   Better before

[tresf]

@musikBear thanks for the feedback, I guess it's up to @dj-pixus to issue another PR with your changes if in agreement.