LadspaManager: Skip empty entries when looking for plugins#5677
Merged
PhysSong merged 1 commit intoLMMS:masterfrom Sep 18, 2020
Merged
LadspaManager: Skip empty entries when looking for plugins#5677PhysSong merged 1 commit intoLMMS:masterfrom
PhysSong merged 1 commit intoLMMS:masterfrom
Conversation
This fixes crashes when starting LMMS from specific working directories.
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Windows
Linux
🤖{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://1138-94782492-gh.circle-artifacts.com/0/lmms-1.2.0.776-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1138?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://1135-94782492-gh.circle-artifacts.com/0/lmms-1.2.0.776-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1135?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/av8cniv308vry23f/artifacts/build/lmms-1.2.2-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35228490"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/22u06vvpuyax87km/artifacts/build/lmms-1.2.2-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35228490"}], "Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://1139-94782492-gh.circle-artifacts.com/0/lmms-1.2.0.776-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1139?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "085b193fbc796fc5bb13c693d2a23e97bcf6fffb"} |
Member
|
Could we pass |
Member
Author
|
That will also work. I simply copied the logic from |
Member
|
Then I suppose it's more consistent this way. |
Spekular
approved these changes
Sep 17, 2020
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
This fixes crashes when starting LMMS from specific working directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2569.