Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LadspaManager: Skip empty entries when looking for plugins #5677

Merged
merged 1 commit into from Sep 18, 2020

Conversation

PhysSong
Copy link
Member

Fixes #2569.

This fixes crashes when starting LMMS
from specific working directories.
@LmmsBot
Copy link

LmmsBot commented Sep 16, 2020

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Windows

Linux

🤖
{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://1138-94782492-gh.circle-artifacts.com/0/lmms-1.2.0.776-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1138?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://1135-94782492-gh.circle-artifacts.com/0/lmms-1.2.0.776-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1135?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/av8cniv308vry23f/artifacts/build/lmms-1.2.2-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35228490"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/22u06vvpuyax87km/artifacts/build/lmms-1.2.2-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35228490"}], "Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://1139-94782492-gh.circle-artifacts.com/0/lmms-1.2.0.776-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1139?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "085b193fbc796fc5bb13c693d2a23e97bcf6fffb"}

@Spekular
Copy link
Member

Could we pass Qt::SkipEmptyParts as an argument to the split calls that populate ladspaDirectories instead? If there are other places where an empty path could be added, I suppose the check against empty paths needs to be kept.

@PhysSong
Copy link
Member Author

That will also work. I simply copied the logic from PluginFactory because it also does this.

@Spekular
Copy link
Member

Then I suppose it's more consistent this way.

@PhysSong PhysSong merged commit 27a9f77 into LMMS:master Sep 18, 2020
@PhysSong PhysSong deleted the zipcrash branch September 18, 2020 06:55
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
This fixes crashes when starting LMMS
from specific working directories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening mmpz from within zip file crashes LMMS
3 participants