Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify DirectConnection for a few plugins #5695

Merged
merged 4 commits into from
Oct 8, 2020
Merged

Conversation

Firepal
Copy link
Contributor

@Firepal Firepal commented Oct 3, 2020

Fixes #5665.
Continues #4942. (somewhat, at least)

(If i understand this problem right,) some knob connections were automatically set to QueuedConnection, which made them update poorly and thus caused audible "snapping" with knob values in knobs that were automated. Manually setting those connections to DirectConnection fixes that.

The following plugins were changed:

  • TripleOscillator
  • BitInvader
  • AudioFileProcessor
  • Monstro
  • Nescaline (haven't tested these last two, but for good measure...)

@LmmsBot
Copy link

LmmsBot commented Oct 3, 2020

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://9250-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-722%2Bg08a4def-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9250?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://9253-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-722%2Bg08a4def3e-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9253?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://9252-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-722%2Bg08a4def3e-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9252?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/is3ws9pnklicdy7b/artifacts/build/lmms-1.2.2-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35552042"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/ghpinvtmchpx7a6x/artifacts/build/lmms-1.2.2-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35552042"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://9249-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-722%2Bg08a4def3e-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9249?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "16bd82c8a887160f3bbc925bbd6787032219fefc"}

@Firepal
Copy link
Contributor Author

Firepal commented Oct 3, 2020

Did it for Nescaline detuning knobs at the last minute. Haven't tested, but looks safe. I won't commit any more changes, you can merge if you want.

Copy link
Member

@DomClark DomClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You could also make the volume and pan connections for TripleOscillator direct (just above the other changes in that file).

@Firepal
Copy link
Contributor Author

Firepal commented Oct 3, 2020

Shoot. Didn't see those, good eye

@DomClark
Copy link
Member

DomClark commented Oct 7, 2020

This can be merged now - I will do so tomorrow if there are no objections.

@DomClark DomClark merged commit 892aec3 into LMMS:master Oct 8, 2020
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LFO Controller/Automation exports poorly
3 participants