Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify DirectConnection for a few plugins #5695

merged 4 commits into from Oct 8, 2020


Copy link

@Firepal Firepal commented Oct 3, 2020

Fixes #5665.
Continues #4942. (somewhat, at least)

(If i understand this problem right,) some knob connections were automatically set to QueuedConnection, which made them update poorly and thus caused audible "snapping" with knob values in knobs that were automated. Manually setting those connections to DirectConnection fixes that.

The following plugins were changed:

  • TripleOscillator
  • BitInvader
  • AudioFileProcessor
  • Monstro
  • Nescaline (haven't tested these last two, but for good measure...)

Copy link

LmmsBot commented Oct 3, 2020

🤖 Hey, I'm @LmmsBot from and I made downloads for this pull request, click me to make them magically appear! 🎩




{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": ""}}, "build_link": ""}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": ""}}, "build_link": ""}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": ""}}, "build_link": ""}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": ""}}, "build_link": ""}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": ""}}, "build_link": ""}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": ""}}, "build_link": ""}]}, "commit_sha": "16bd82c8a887160f3bbc925bbd6787032219fefc"}

Copy link
Contributor Author

Firepal commented Oct 3, 2020

Did it for Nescaline detuning knobs at the last minute. Haven't tested, but looks safe. I won't commit any more changes, you can merge if you want.

Copy link

@DomClark DomClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You could also make the volume and pan connections for TripleOscillator direct (just above the other changes in that file).

Copy link
Contributor Author

Firepal commented Oct 3, 2020

Shoot. Didn't see those, good eye

Copy link

DomClark commented Oct 7, 2020

This can be merged now - I will do so tomorrow if there are no objections.

@DomClark DomClark merged commit 892aec3 into LMMS:master Oct 8, 2020
7 checks passed
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

LFO Controller/Automation exports poorly
3 participants