Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insert/remove bar buttons in Song editor #5698

merged 1 commit into from Oct 4, 2020


Copy link

Added two buttons for the shortcuts insert and remove bar #5602

This is my first ever pull request and piece of C++ code, so forgive any errors.


Copy link

LmmsBot commented Oct 3, 2020

🤖 Hey, I'm @LmmsBot from and I made downloads for this pull request, click me to make them magically appear! 🎩




{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": ""}}, "build_link": ""}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": ""}}, "build_link": ""}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": ""}}, "build_link": ""}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": ""}}, "build_link": ""}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": ""}}, "build_link": ""}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": ""}}, "build_link": ""}]}, "commit_sha": "9263a21cc4c9be7bb76f8260be8daca9df3a3cfd"}

@JohannesLorenz JohannesLorenz self-requested a review October 4, 2020 12:50
Copy link

JohannesLorenz commented Oct 4, 2020

@allejok96 I get an error while starting LMMS:

Error loading icon pixmap "insert_bar": File not found
Error loading icon pixmap "remove_bar": File not found

Indeed, I see not pixmaps on the new buttons. Did you forget to add them to your commit?

Edit: I see the pixmaps are in default theme, which I have selected ✔️ However, they are not installed yet.

Copy link
Contributor Author

allejok96 commented Oct 4, 2020

@JohannesLorenz Will the error fix itself or do I need to change anything?
And does classic theme need the icons too? Ah, it grabs them from default if they are missing...

Copy link

Will the error fix itself

Indeed! I had to do a make clean and a further make install to get it run. Seems like a bug of the build system.

Now going on with the review...

Copy link

@JohannesLorenz JohannesLorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@JohannesLorenz JohannesLorenz merged commit 8939b14 into LMMS:master Oct 4, 2020
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants