-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Carla support for Windows #5713
Conversation
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://9490-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-734%2Bgcf4fd59-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9490?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://9492-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-734%2Bgcf4fd599b-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9492?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://9494-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-734%2Bgcf4fd599b-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9494?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/96ce805xn32h0stw/artifacts/build/lmms-1.2.2-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35779079"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/k7a19v4o7a4bppov/artifacts/build/lmms-1.2.2-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35779079"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://9493-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-734%2Bgcf4fd599b-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9493?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "2f7b60806d4a0463ace04c2cddcf547ef35bd138"} |
Reproduced with Carla 2.2 and MSVC build of LMMS. It seems like Carla crashed in |
I found that it's related to the (improperly implemented) |
@PhysSong would you like to wait to merge this PR until the bug is resolved, or merge and open a new issue? |
Merging. I'll open a new issue for the crash. |
Windows adds both to the search PATH. Either will work. |
Gotcha, I put Carla's path under the System Variables and it worked fine. Its been a long while since I made any form of music that I have forgotten where to put the things. Thank you so much. |
Greetings everyone. I'm really sorry for asking this, but.... I've tried to make Carla work on LMMS in Windows, and still I couldn't get it to work (nothing showed up in my LMMS's 'Instrument' list). From what I can understand from this thread, I just have to extract Carla to a filepath (as in any filepath), and add a filepath to that Carla's main folder (the folder with 4 versions of it; Vst, Lv2, etc.) into Windows' PATH, is that correct? Again, I'm really sorry for the trouble, and thanks alot in advance~ ._.v |
I think it broke per: #6726. In short, this means you'd have to be on an unstable build for it to work (or on much older version of Carla). |
Hmmmm, okay, I think I get the gist of it....? (and thanks alot for replying! :D) So.... by unstable build, did you mean the most recent LMMS Nightly version (which I'm using rn; 1.3.0-alpha+g360254fd8), or is this one meant for Carla? As for older version of Carla, unfortunately last time I checked Carla's releases on github, the oldest windows zip available are version 2.5.5., which I'm guessing is probably not old enough. |
That was my initial observation as well until I checked archive.org to dates closer to writing this feature... and it appears Carla for Windows goes back to at least version 2.0.0. It just so happens that you have to navigate back to find them. |
Yes, I think so (the nightly) since the "alpha" download listed on the downloads page would be too old for that patch to make it in. |
Linking a relevant conversation from the last time I tried this... #5984 (comment) |
Yes, found it! Thanks for letting me know that one. 👍 Someone also mentioned something about using KushView's 'Element' as a workaround. But I'll just turn to LMMS forums for that one since that's where I got that info in the first place (also it doesn't quite fit in here I think....). I did make a post there, though still waiting for any responses. Thank you so much for your assistance btw! Sure things didn't work out very well, but still really glad that I finally got some answers. Hopefully this issue can be resolved one day~ :D |
Hmm... weird. I would expect it to work just fine. I'll try in a VM real quick and see what happens. |
Steps:
|
Oh wait, You managed to get it to work? That's awesome! :D One small question though, how do I do this part?
Because I tried to drag the Carla folder and the Carla.exe into LMMS's window. But it wont let me. It kept giving me the No sign (the 'No Entry' thing) |
Sorry, open the plugins sidebar in LMMS, drag in the Carla Patchbay or Carla Plugin Host into an empty area in the LMMS Song Editor. |
Okay, got it. Sorry, I thought I had to add Carla like a some sort of wrapper or something. That was my fault for not taking a closer look at the pic. I'm pretty sure I've tried that before and it didn't work. But just to not second guess myself, I decided to start over (uninstall LMMS) and follow your steps one-to-one. But at the very least I know that it Should've worked in the first place. It's just that my PC somehow keeps running into a weird issue, yet I still can't figure out what is it or why.... (Idk, I've been reinstalling LMMS tens of times at this point, I'm pretty much losing my mind rn). I also see that you're using Win11 on your VM. I'm using Windows 10, I wonder if that matters by any chance..... edit: |
LMMS shouldn't really need to be "reinstalled". Besides the file associations (e.g.
When you say "does not work", can you be more specific? For example, is Carla missing completely from the plugins section? If not, when you drag it in, what happens? You may have to click the "Show GUI" button for it to appear. |
Yes, that is true. But the reason I had to is because I'm normally storing my LMMS in D: drive. And with how specific some of the steps and methods I found, I thought that was the major factor of the issue. So I just kept installing in C: and D: back and forth, trying to find out if that mattered or not. (and the same with Carla, copying the folder to C: or D: and assigning its PATH accordingly)
'aight, that's good to know. Seems there's still a chance~ :)
A part of me thinks the same too, but the fact that it worked instantly on a newly installed Windows, makes me wondering if there are some underlying issues that I just couldn't figure out at all, so it might be worth a try,
Yea it's the former. Carla is just... not there, none of them. Couldn't be found in the plugins section at all... So.... this .lmmsrc.xml file, does it affect the LMMS's ability to search for Carla, or is it solely done from within LMMS directly (with the help of PATH of course)? edit: |
Currently Carla isn't a configured path. There is a good argument to change this, but for now, it's not affected by the settings file.
Right, no reboot needed. You'll only need to restart LMMS if it's open. If you want, feel free to jump on Discord and PM me. Maybe there's something one of us is missing. https://lmms.io/chat. My name there is the same as it is here. |
This suggests that you did not properly set With regards to Carla not working properly, that may be true. I haven't actually tested it recently... Let me see if I can get a VST2 working. |
Yeah, that's the thing. I've been doing that, and making sure to do so between tests. Set the PATH; click OK; then OK again to apply changes and close 'Environment Variables' window, and that should be enough. I even tried that again just now, because I second guessed myself. Set Carla's PATH; click OK; close all dialog and windows leading to the Environment Variables properly (including 'Advanced System Settings' window). And it did nothing (I swear, my PC is really something else ><) As for Carla's plugins, can confirm as well that VST2 still works. Does LV2 and VST3 also work? |
I'd expect both LV2 and VST3 to work. I can't say I've tested either though. 🍻 |
That's odd. By chance are you telling the computer to run LMMS as another user? When you set PATH are you doing it in the USER section or the SYSTEM section? (Both should work, just curious) |
Had to double-check that one as well. And yeah, adding it into USER variables didn't work either.....
I still have not gotten my hand on an LV2 plugin to test that yet, but on my end VST3 just freezes Carla (I tested that with Camomile and chowdsp's 'ChowMultiTool', as they're the only ones that I have rn) |
Based on what I am reading here. I can install LMMS freely somewhere else or am I understanding this completely wrong? |
LMMS doesn't take up that much space, but yes, you may install it wherever you like. |
I have tried this before, with plugins on the same page but somehow it did not pick up my plugins? I guess I was dumb not pointing LMMS to the same drive letter it is on? |
The plugins folders for LMMS can be adjusted to whichever drive letter you want after install. It's your choice and any configuration should work. Note that Carla on MacOS is a bit different and it is expected to be installed on the same drive as LMMS, but since this conversation is about Windows, I think you'll be fine regardless of where you choose to install. |
Awesome, allow me to try and if I run into any issues, I will open a seperate issue for it. Currently mainly using the Alpha 1 of 1.3.0 as I could not get Carla picked up in the latest Nightly. |
Closes #4654
This PR should be safe for backport to 1.2.x if needed.
What the PR does:
libcarla_native-plugin.dll
tocarla.dll
to match that of the Windows releasePATH
conflict preventing Carla from finding PyQtSteps to use Carla with LMMS:
Carla.lv2
to yourPATH
environment variable (e.g.C:\Carla_2.2.0-win64\Carla.lv2
)Known issues: