Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the unit of Bitcrush Output clip level from % to dBFS #5870

Merged
merged 1 commit into from Jan 2, 2021

Conversation

deenadayalancs
Copy link
Contributor

Added the code outClip->setHintText( tr( "Output clip:" ) , " dBFS"); to fix the

"Bitcrush plugins displays output clip level as % while it's dBFS #5856 " @PhysSong

Added the code outClip->setHintText( tr( "Output clip:" ) , " dBFS"); to fix the 

"Bitcrush plugins displays output clip level as % while it's dBFS LMMS#5856 " @PhysSong
@LmmsBot
Copy link

LmmsBot commented Jan 2, 2021

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://11967-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.60%2Bg69eef12-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11967?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://11965-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.60%2Bg69eef12ba-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11965?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://11968-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.60%2Bg69eef12ba-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11968?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/710ptsecamvqfv3j/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37073633"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/oc6kk9bc2337nn1e/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37073633"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://11969-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.60%2Bg69eef12ba-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11969?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "08ae387cf09c12ad2eb468563eb1fc9cfde2c909"}

@PhysSong PhysSong merged commit 24761a4 into LMMS:master Jan 2, 2021
@PhysSong PhysSong changed the title Update BitcrushControlDialog.cpp Fix the unit of Bitcrush Output clip level from % to dBFS Jan 2, 2021
@PhysSong PhysSong linked an issue Jan 2, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitcrush plugins displays output clip level as % while it's dBFS
3 participants