Fix 32-bit winegcc call on Linux when using LLD

[rdrpenguin04]

No description provided.

[LmmsBot]

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

• Linux (AppImage): lmms-1.3.0-alpha.1.64%2Bg57587bb-linux-x86_64.AppImage (build link)

Windows

• Windows 32-bit: lmms-1.3.0-alpha.1.64%2Bg57587bb1f-mingw-win32.exe (build link)
• Windows 64-bit: lmms-1.3.0-alpha.1.64%2Bg57587bb1f-mingw-win64.exe (build link)

macOS

• macOS : lmms-1.3.0-alpha.1.64%2Bg57587bb1f-mac10.14.dmg (build link)

🤖

{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://12081-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.64%2Bg57587bb-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12081?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://12084-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.64%2Bg57587bb1f-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12084?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://12085-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.64%2Bg57587bb1f-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12085?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://12083-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.64%2Bg57587bb1f-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12083?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "caf3ec5cce77bfd66dacc3b7670b655c7d0b94c7"}

[PhysSong]

Possibly related: #5024
See also: llvm/llvm-project@0a7412f

[rdrpenguin04]

That other issue could be related; since lld blocks text relocations by default, it was a hard error for me.

The commit you referenced seems to be implementing the -z notext flag, not setting it as the default. I run main branch LLVM, so if it was made the default, I would have it by now.

This commit simply adds the flag so that RemotePluginVST32 will build and work properly, and, as I have stated, I have tested it on a 32-bit VST that I have.

[PhysSong]

LGTM. Please revert the last commit, BTW. The CONTRIBUTORS file is a fallback for automatically generated file, so it should probably be regenerated properly if it needs updating.

[rdrpenguin04]

K, will do.