Fix MP3 stereo mode doesn't match to the selection in export dialog - #5890
Merged
Conversation
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://12210-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.64%2Bg2d93b48-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12210?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://12208-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.64%2Bg2d93b485c-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12208?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://12207-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.64%2Bg2d93b485c-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12207?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/e7i1opxnvsbcujob/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37398820"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/l9rism81dh6pyx6w/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37398820"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://12206-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.64%2Bg2d93b485c-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12206?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "c587a10774e1eff81d19e3a941357e114f726292"} |
zonkmachine
reviewed
Jan 21, 2021
zonkmachine
left a comment
zonkmachine
left a comment
Contributor
There was a problem hiding this comment.
I've tested the PR and it fixes the issue. I suggest some style changes while you're at it. See comment below.
| return OutputSettings::StereoMode_Mono; | ||
| return OutputSettings::StereoMode_JointStereo; | ||
| default: | ||
| return OutputSettings::StereoMode_Stereo; |
Contributor
There was a problem hiding this comment.
Please add an extra tab to everything withing the brackets
{
like
this
}
Member
There was a problem hiding this comment.
We don't have a rule for switch statement, so it's fine.
PhysSong
reviewed
Jan 22, 2021
Accepting the suggestion. Thanks Co-authored-by: Hyunjin Song <tteu.ingog@gmail.com>
PhysSong
changed the title
IanCaio
pushed a commit
to IanCaio/lmms
that referenced
this pull request
Mar 28, 2021
devnexen
pushed a commit
to devnexen/lmms
that referenced
this pull request
Apr 10, 2021
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for MP3 stereo mode doesn't match to the selection in export dialog #5876
Updated the code to match the #5876.