Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MP3 stereo mode doesn't match to the selection in export dialog #5890

Merged
merged 2 commits into from Jan 23, 2021

Conversation

deenadayalancs
Copy link
Contributor

Fix for MP3 stereo mode doesn't match to the selection in export dialog #5876

Updated the code to match the #5876.

Fix for MP3 stereo mode doesn't match to the selection in export dialog LMMS#5876

Updated the code to match the LMMS#5876.
@LmmsBot
Copy link

LmmsBot commented Jan 21, 2021

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://12210-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.64%2Bg2d93b48-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12210?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://12208-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.64%2Bg2d93b485c-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12208?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://12207-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.64%2Bg2d93b485c-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12207?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/e7i1opxnvsbcujob/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37398820"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/l9rism81dh6pyx6w/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37398820"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://12206-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.64%2Bg2d93b485c-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12206?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "c587a10774e1eff81d19e3a941357e114f726292"}

Copy link
Member

@zonkmachine zonkmachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the PR and it fixes the issue. I suggest some style changes while you're at it. See comment below.

case 2:
return OutputSettings::StereoMode_Mono;
return OutputSettings::StereoMode_JointStereo;
default:
return OutputSettings::StereoMode_Stereo;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an extra tab to everything withing the brackets

{
    like
    this
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a rule for switch statement, so it's fine.

Accepting the suggestion. Thanks

Co-authored-by: Hyunjin Song <tteu.ingog@gmail.com>
@PhysSong PhysSong changed the title Update ExportProjectDialog.cpp Fix MP3 stereo mode doesn't match to the selection in export dialog Jan 23, 2021
@PhysSong PhysSong merged commit 1744fd7 into LMMS:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants