Skip to content

Fix Ghost Notes aren't displayed properly after loading a project - #5916

Merged
Veratil merged 1 commit into
LMMS:masterfrom
cyber-bridge:ghost_fix
Apr 15, 2021
Merged

Fix Ghost Notes aren't displayed properly after loading a project#5916
Veratil merged 1 commit into
LMMS:masterfrom
cyber-bridge:ghost_fix

Conversation

@cyber-bridge

Copy link
Copy Markdown
Contributor

Fixes #5912

@IanCaio IanCaio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LmmsBot

LmmsBot commented Feb 22, 2021

Copy link
Copy Markdown
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Windows

Linux

macOS

🤖
{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://12604-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.69%2Bg6d8c2728c-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12604?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://12603-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.69%2Bg6d8c2728c-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12603?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/fjlujf38a45o2hm8/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37898506"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/afvt9dhawf7eh1g2/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37898506"}], "Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://12605-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.69%2Bg6d8c272-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12605?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://12602-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.69%2Bg6d8c2728c-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12602?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "ee4aee74e0c62c35ee05db60c1776e4d59cb8e94"}

@akimaze

akimaze commented Apr 15, 2021

Copy link
Copy Markdown
Contributor

Hi, @IanCaio that PR is just one line and have 2 approvals. Maybe should be merged?

@Veratil
Veratil merged commit 4536996 into LMMS:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.3 Alpha - Ghost Notes aren't displayed properly after loading a project

6 participants