Fixes small bug on #5848 - #5933
Merged
Merged
Conversation
m_gridMode was not being initialized on the PianoRoll constructor. For that reason the first note drag without changing the GridMode would result in m_gridMode being used unintialized and neither the Snap nor Nudge mode being used. Here, the result of this was a note being moved unquantized. This fixes it by calling changeSnapMode() after setting up the snapModel on the constructor.
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Windows
Linux
macOS🤖{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://12807-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.73%2Bgf7ee3c6a0-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12807?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://12806-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.73%2Bgf7ee3c6a0-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12806?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/008n5gg7lev9cx8d/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/38086323"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/gv9i8xg2o4rstf4g/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/38086323"}], "Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://12810-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.73%2Bgf7ee3c6-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12810?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://12809-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.73%2Bgf7ee3c6a0-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12809?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "0fd0124741e076ce617f6212468be7ceb17d360d"} |
Veratil
approved these changes
Mar 5, 2021
IanCaio
added a commit
to IanCaio/lmms
that referenced
this pull request
Mar 28, 2021
m_gridMode was not being initialized on the PianoRoll constructor. For that reason the first note drag without changing the GridMode would result in m_gridMode being used unintialized and neither the Snap nor Nudge mode being used. Here, the result of this was a note being moved unquantized. This fixes it by calling changeSnapMode() after setting up the snapModel on the constructor.
devnexen
pushed a commit
to devnexen/lmms
that referenced
this pull request
Apr 10, 2021
m_gridMode was not being initialized on the PianoRoll constructor. For that reason the first note drag without changing the GridMode would result in m_gridMode being used unintialized and neither the Snap nor Nudge mode being used. Here, the result of this was a note being moved unquantized. This fixes it by calling changeSnapMode() after setting up the snapModel on the constructor.
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
m_gridMode was not being initialized on the PianoRoll constructor. For that reason the first note drag without changing the GridMode would result in m_gridMode being used unintialized and neither the Snap nor Nudge mode being used. Here, the result of this was a note being moved unquantized. This fixes it by calling changeSnapMode() after setting up the snapModel on the constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m_gridModewas not being initialized on the PianoRoll constructor. For that reason the first note drag without changing the GridMode would result in m_gridMode being used unintialized and neither the Snap nor Nudge mode being used. Here, the result of this was a note being moved unquantized.This fixes it by calling changeSnapMode() after setting up the snapModel on the constructor.