Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in the AutomationPattern copy-ctor #5968

Merged
merged 1 commit into from Apr 2, 2021

Conversation

IanCaio
Copy link
Contributor

@IanCaio IanCaio commented Mar 28, 2021

On the AutomationPattern copy constructor, the automation nodes were copied from the origin pattern but their "owner pattern" pointers weren't updated.

Thanks @DomClark for finding and reporting this bug.

	On the AutomationPattern copy constructor, the automation nodes
were copied from the origin pattern but their "owner pattern" pointers
weren't updated.
	Thanks Dom for finding and reporting this bug.
@LmmsBot
Copy link

LmmsBot commented Mar 28, 2021

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Windows

Linux

macOS

🤖
{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://13277-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.87%2Bg5293d4f11-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/13277?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://13278-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.87%2Bg5293d4f11-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/13278?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/alo9cjxmij819geh/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/38436980"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/ay4jjrgh7bcvguil/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/38436980"}], "Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://13279-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.87%2Bg5293d4f-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/13279?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://13280-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.87%2Bg5293d4f11-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/13280?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "7e7187cc6936f3be037ca80ebddb43bf84bab46f"}

Copy link
Member

@Spekular Spekular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IanCaio
Copy link
Contributor Author

IanCaio commented Apr 2, 2021

Merging this one tonight if no one opposes, it being such a small fix.

@IanCaio IanCaio merged commit c50ff06 into LMMS:master Apr 2, 2021
devnexen pushed a commit to devnexen/lmms that referenced this pull request Apr 10, 2021
On the AutomationPattern copy constructor, the automation nodes
were copied from the origin pattern but their "owner pattern" pointers
weren't updated.
	Thanks Dom for finding and reporting this bug.
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
On the AutomationPattern copy constructor, the automation nodes
were copied from the origin pattern but their "owner pattern" pointers
weren't updated.
	Thanks Dom for finding and reporting this bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants