New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulldozer in Piano roll #6497
base: master
Are you sure you want to change the base?
Bulldozer in Piano roll #6497
Conversation
ActionChangeNoteProperty, | ||
ActionResizeNoteEditArea, | ||
ActionKnife | ||
ActionNone = 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably update this to an enum class. https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#enum3-prefer-class-enums-over-plain-enums
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. I don't have much to say but basically use auto
and make variables immutable where applicable. I'm not sure how the surrounding code uses the variables I made const
however, so if necessary, you can remove const
(or any other needed change) to make the code compile.
Made it draft since |
New edit mode to quickly scale and move things around. Stems from #6140. Forgive the bad English.
bulldozer.mp4
Didn't want to wait for piano roll rewrite any more. Needed this feature.
New stuff
Bugs fixed
Needs testing
Beware of bugs
I know there's a ton in the old code. I didn't want to fix them to keep the PR clean, but some of them just had to go. Hope I didn't introduce that many new though.