Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Enhancement: Add "Send All Funds" button in pay view for on-chain transactions #142

Closed
thinkjanis opened this issue Dec 29, 2017 · 2 comments

Comments

@thinkjanis
Copy link
Contributor

commented Dec 29, 2017

Detailed Description

Add option to send all on-chain funds shows up when pasting in a BTC address in pay view.

Context

Improve usability of Pay form

Possible Implementation

  • Add a Toggle switch to the bottom of the amount section of the Pay form
  • When selected, the populate the amount fields with the full on-chain balance and disable the amount fields
  • When deselected, re-enable the amount fields
  • When sending, pass the send_all flag to `sendCoins - see https://api.lightning.community/#sendcoins

image

image

@thinkjanis thinkjanis changed the title Add "Send All Funds" button in pay view for on-chain transactions UX Enhancement: Add "Send All Funds" button in pay view for on-chain transactions Jan 28, 2018

@mrfelton mrfelton added this to the v0.3.1-beta milestone Dec 4, 2018

@mrfelton mrfelton modified the milestones: v0.3.1-beta, v0.4.0-beta Dec 21, 2018

@mrfelton mrfelton modified the milestones: v0.4.0-beta, v0.5.0-beta Jan 8, 2019

@brandoncurtis

This comment has been minimized.

Copy link

commented Feb 5, 2019

I would also love this feature. I just wanted to point out that an LND API change that was recently merged in could enable this feature:

multi: add ability to sweep all coins in the the wallet to an addr to sendcoins
lightningnetwork/lnd#2198

@mrfelton mrfelton removed this from the v0.5.0-beta milestone Mar 4, 2019

@mrfelton mrfelton added this to the v0.5.0-beta milestone Mar 11, 2019

@mrfelton mrfelton assigned mrfelton and unassigned mrfelton Mar 12, 2019

@mrfelton mrfelton self-assigned this Apr 4, 2019

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Apr 4, 2019

@mrfelton mrfelton referenced this issue Apr 4, 2019

Merged

feat(wallet): ability to sweep on-chain balance #1952

4 of 6 tasks complete

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Apr 5, 2019

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Apr 5, 2019

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Apr 5, 2019

@mrfelton

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

Closed via #1952

@mrfelton mrfelton closed this Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.