Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling for extremely long wallet names #1529

Closed
lieteau2 opened this issue Feb 7, 2019 · 2 comments

Comments

@lieteau2
Copy link
Member

commented Feb 7, 2019

add a character limit to the wallet names so as if to minimize UI/UX disruptions

Possible Fix

introduce a character limit to the wallet name

Steps to Reproduce

use an extremely long wallet name

  • Zap Desktop version: 0.3.4-beta
  • Operating System and version: mac osX

@mrfelton mrfelton added this to the v0.5.0-beta milestone Mar 11, 2019

@mrfelton mrfelton changed the title Extremely long Wallet Names Better handling for extremely long wallet names Mar 11, 2019

@bolatovumar

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

Some screenshots of the UI when the wallet name is really long:

Screen Shot 2019-03-12 at 8 07 40 PM
Screen Shot 2019-03-12 at 8 14 40 PM
Screen Shot 2019-03-12 at 8 17 52 PM

It seems like a 30 character limit would be work well.

bolatovumar added a commit to bolatovumar/zap-desktop that referenced this issue Mar 13, 2019

@mrfelton mrfelton self-assigned this Apr 23, 2019

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Apr 25, 2019

@mrfelton mrfelton referenced this issue Apr 25, 2019

Merged

fix(ui): constrain wallet name to 30 chars max #2116

4 of 5 tasks complete
@mrfelton

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

Closed via #2116

@mrfelton mrfelton closed this Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.