Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When connecting to a remote server with an invalid tls cert, I should be told that the cert is the problem #1564

Closed
mrfelton opened this issue Feb 13, 2019 · 2 comments

Comments

1 participant
@mrfelton
Copy link
Member

commented Feb 13, 2019

Detailed Description

When you connect to a remote node using an invalid tls cert, the connection attempt will timeout after 20 seconds. The error message that the user sees is a generic "could not connect before the deadline" message, which doesn't help users identify the problem.

Context

Users having trouble diagnosing connection issues

Possible Implementation

Intercept grpc and stop early if a bad tls handshake is encountered.

Your Environment

  • Zap Desktop version: 0.3.4
  • Operating System and version: all
@mrfelton

This comment has been minimized.

Copy link
Member Author

commented Feb 13, 2019

@mrfelton mrfelton self-assigned this May 15, 2019

@mrfelton mrfelton added this to the v0.5.0-beta milestone May 15, 2019

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue May 15, 2019

@mrfelton

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

Closed via #2206

@mrfelton mrfelton closed this May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.