Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing the app window when on full screen will leave a black screen #1893

Closed
otaviobps opened this Issue Mar 25, 2019 · 4 comments

Comments

2 participants
@otaviobps
Copy link

commented Mar 25, 2019

Description

When the app is running on full screen mode, on OSX, exiting the app will bring a black screen and the app will continue to run.

Expected Behavior

The app should close.

Actual Behavior

The app won't close, instead a black screen is shown

Possible Fix

I'm not a JS dev, so I really don't know how it's possible to fix it.

Steps to Reproduce

    1. Open the app
    1. Switch to full screen
    1. Exit the app

Your Environment

  • Zap version: v.0.4
  • Operating System and version: Mac OSX Mojave 10.14.3

image

@mrfelton

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

Hi @otaviobps - I've been unable to reproduce this issue. Does it reliably reproduce for you?

If so, please can you provide exact steps to reproduce (have you created a wallet? are you connecting to your own node or using the built in neutrino client? are you logged into a wallet when you quit? is the app in the middle of syncing when you quit? etc etc). I want to understand exactly what state your app is in when this happens.

Perhaps you could provide a video that shows exactly what you do to make this happen?

Thanks!

@otaviobps

This comment has been minimized.

Copy link
Author

commented Mar 26, 2019

Hi @mrfelton, I've noticed this bug is not exclusively to your app, a few others have the same behavior. It doesn't mind the state the app is, if maximize it and close it, the bug happens.

I'm attaching the video

ZapBug

@mrfelton

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

Thanks @otaviobps . I can reproduce this and will look into it. I guess it's probably an Electron issue rather than anything Zap specific.

One thing to note is that clicking the red close button does not exit the app, it only closes the window. The app in only minimised and continues to run. It will still be in your dock, and can be maximised again by clicking on the app in the dock.

To actually exit the app you should choose Quit from the Zap menu, or press cmd+q

@mrfelton mrfelton added this to the v0.4.1-beta milestone Mar 26, 2019

@otaviobps

This comment has been minimized.

Copy link
Author

commented Mar 26, 2019

To actually exit the app you should choose Quit from the Zap menu, or press cmd+q

Yes, I noticed this. However the behavior of the app is strange when you click on the red close button if it's maximized. When you open again the app, it looks very small, like it's in the video. Yes, probably is something with Electron

@mrfelton mrfelton self-assigned this Mar 31, 2019

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Mar 31, 2019

fix(electron): exit fullscreen before closing
On mac, closing the main window when the app is in fullscreen mode
results in a black screen. To resolve this, ensure that we exit
fullscreen mode before hiding the app.

Fix LN-Zap#1893

See electron/electron#6033

@mrfelton mrfelton referenced this issue Mar 31, 2019

Merged

fix(electron): exit fullscreen before closing #1923

4 of 6 tasks complete

@mrfelton mrfelton changed the title Exiting the app when on full screen will leave a black screen Closing the app window when on full screen will leave a black screen Mar 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.