Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes if channel close complete whilst channel detail modal is open #1996

Closed
mrfelton opened this issue Apr 10, 2019 · 0 comments

Comments

3 participants
@mrfelton
Copy link
Member

commented Apr 10, 2019

Description

App crashes if channel close complete whilst channel detail modal is open

Steps to Reproduce

Close a channel
Leave the channel detail modal open until the channel is fully closed
UI will crash when the final update notification comes in and changes the status from closing to closed

Uncaught TypeError: Cannot read property 'channel_point' of undefined
    at channel_point (webpack:/renderer/reducers/utils.js:93)
    at eval (index.js:75)
    at eval (index.js:35)
    at eval (index.js:89)
    at eval (index.js:35)
    at Function.mapStateToProps [as mapToProps] (webpack:/renderer/containers/Channels/ChannelDetail.js:11)
    at mapToPropsProxy (wrapMapToProps.js:46)
    at handleNewState (selectorFactory.js:50)
    at handleSubsequentCalls (selectorFactory.js:64)
    at pureFinalPropsSelector (selectorFactory.js:69)

@mrfelton mrfelton added this to the v0.4.1-beta milestone Apr 10, 2019

@korhaliv korhaliv self-assigned this Apr 10, 2019

@JimmyMow JimmyMow modified the milestones: v0.4.1-beta, v0.5.0-beta Apr 11, 2019

@mrfelton mrfelton modified the milestones: v0.5.0-beta, v0.4.2-beta Apr 12, 2019

korhaliv added a commit to korhaliv/zap-desktop that referenced this issue Apr 12, 2019

korhaliv added a commit to korhaliv/zap-desktop that referenced this issue Apr 16, 2019

@mrfelton mrfelton modified the milestones: v0.4.2-beta, v0.5.0-beta Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.