Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero value invoices don't display the amount paid after settled #2047

Closed
Fi3 opened this issue Apr 16, 2019 · 9 comments

Comments

3 participants
@Fi3
Copy link

commented Apr 16, 2019

Description

Any amounts invoices are showing an incorrect amount.

Expected Behavior

The invoice amount should be correct.

Actual Behavior

Any amounts invoices always show 0 for the amount.

Steps to Reproduce

    1. Create an invoice with 0 sat
    1. Pay it with n sat with n > 0
    1. You balance is not updated, in the tx list you see a payment of 0 sat, the channel balances are not updated

Your Environment

  • Zap Desktop version: master
@welcome

This comment has been minimized.

Copy link

commented Apr 16, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@Fi3 Fi3 changed the title Any amount invoices amount always shows as 0 on invoice detail page Any amount invoices amount shows as 0 Apr 16, 2019

@JimmyMow

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Hey @Fi3, thanks for filing an issue.

I'm having trouble understanding the problem your facing. What exactly is the issue? I've tried to reproduce what you've described above and all my invoices are showing correct amounts.

@Fi3

This comment has been minimized.

Copy link
Author

commented Apr 16, 2019

  1. I create an invoice and I put 0 satoshis as amount, so an invoice that start with lntb1p (tried only in testnet).
  2. From another client I pay the invoice putting an amount that is not 0 (ex 50000 sat)
  3. In the tx list I can see a received payment for that invoice but the showed amount is 0 instead of 50000.
@JimmyMow

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Ah, understood. 0 value invoices don't display the amount that is paid after they are settled

@JimmyMow JimmyMow changed the title Any amount invoices amount shows as 0 Zero value invoices don't display the amount paid after they are settled Apr 16, 2019

@JimmyMow JimmyMow changed the title Zero value invoices don't display the amount paid after they are settled Zero value invoices don't display the amount paid after settled Apr 16, 2019

@mrfelton mrfelton added this to the v0.4.2-beta milestone Apr 16, 2019

@mrfelton mrfelton self-assigned this Apr 16, 2019

@mrfelton

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

@Fi3 I'm unable to reproduce this issue.

What I tried:

  1. Got the QR code on https://tippin.me/@mrfelton
  2. Opened in Zap
  3. Entered a custom payment amount of 1000 Satoshis and paid the invoice

Lightning payment of 1000 sats shows up in the activity list
Clicking on the payment to see the details showed the amount as 1000 sats
Balance decreased by 1000 sats

Please note that 0 value on-chain transactions do sometimes show in the transaction list which are a bi-product of some lnd internals. I wonder if it's one of these that you are seeing?

@Fi3

This comment has been minimized.

Copy link
Author

commented Apr 17, 2019

@mrfelton

I think that you are trying the other way around. I create the 0 value invoice from Zap, and then I pay it from another wallet.

In the tx list I have:

Received payment                                        + 0 tsatoshis
1:29 PM                                                       $0.00

If I click on the tx I get the right tx values:

                           Received
                      Lightning Payment
------------------------------------------------------------
Amount                                             tsatoshis
                                                         500
------------------------------------------------------------
Current value                                            USD
                                                        0.03
------------------------------------------------------------
.....

Also the wallet amount and the channel balances shows a value that is not updated.

@mrfelton

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

@Fi3 Are you using Zap's built in lnd node, or are you connected to your own lnd node? If so, what lnd version are you running?

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Apr 17, 2019

@mrfelton

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

@Fi3 I was able to reproduce and have a fix in #2053

In my testing though, the wallet balances are updated correctly (with lnd 0.6). What version of lnd are you using?

@Fi3

This comment has been minimized.

Copy link
Author

commented Apr 17, 2019

@mrfelton ty
Im using Zap's built in lnd node, the Zap vesrion is 0.4.1.

@mrfelton mrfelton modified the milestones: v0.4.2-beta, v0.5.0-beta Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.