Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet duplicates can appear during creation process #2087

Closed
korhaliv opened this issue Apr 23, 2019 · 1 comment

Comments

2 participants
@korhaliv
Copy link
Member

commented Apr 23, 2019

Description

Next button is not disabled while Zap creates new wallet.
Clicking on it creates wallet dupes
image

Possible Fix

  1. Disable button while creation process is running (ui level)
  2. Don't allow to create a wallet with the same settings while creation process is running (app logic level)

Steps to Reproduce

  1. Press create new wallet
  2. Generate seed
  3. Enter seed
  4. While the wallet is in the process of creation - press Next

@korhaliv korhaliv added this to the v0.5.0-beta milestone Apr 23, 2019

@mrfelton mrfelton self-assigned this Apr 23, 2019

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Apr 23, 2019

fix(onboarding): prevent duplicate wallet entries
Lock the create/import wallet form submit button whilst the wallet is
in the process of being created to prevent duplicate submissions.

Fix LN-Zap#2087

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Apr 23, 2019

fix(onboarding): prevent duplicate wallet entries
Lock the create/import wallet form submit button whilst the wallet is
in the process of being created to prevent duplicate submissions.

Fix LN-Zap#2087

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Apr 23, 2019

fix(onboarding): prevent duplicate wallet entries
Lock the create/import wallet form submit button whilst the wallet is
in the process of being created to prevent duplicate submissions.

Fix LN-Zap#2087

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Apr 23, 2019

fix(onboarding): prevent duplicate wallet entries
Lock the create/import wallet form submit button whilst the wallet is
in the process of being created to prevent duplicate submissions.

Fix LN-Zap#2087

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Apr 23, 2019

fix(onboarding): prevent duplicate wallet entries
Lock the create/import wallet form submit button whilst the wallet is
in the process of being created to prevent duplicate submissions.

Fix LN-Zap#2087

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Apr 24, 2019

fix(onboarding): prevent duplicate wallet entries
Lock the create/import wallet form submit button whilst the wallet is
in the process of being created to prevent duplicate submissions.

Fix LN-Zap#2087

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Apr 24, 2019

fix(onboarding): prevent duplicate wallet entries
Lock the create/import wallet form submit button whilst the wallet is
in the process of being created to prevent duplicate submissions.

Fix LN-Zap#2087
@mrfelton

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

Closed via #2101

@mrfelton mrfelton closed this Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.