Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing hints for private channel invoice #2165

Closed
MaxHillebrand opened this issue May 6, 2019 · 5 comments

Comments

2 participants
@MaxHillebrand
Copy link

commented May 6, 2019

Problem

The creation of private channels is already possible in Zap, thanks!
When running private channels, the public network does not know about the possible routes for sending payments to the private node.

Solution

The receiver can include routing hints within the invoice he provides to the sender.
lncli addinvoice --private --amt <sat>
Feature request to include a check box with Include routing hint in the invoices tab.

Context

Muh privacy.

Possible Implementation

@JimmyMow and @mrfelton have already discussed this many blocks ago, I'm not sure if this is implemented already, but I don't see the option in the GUI.

  • Zap version: 0.4.1-beta
  • Operating System and version: Debian 9
@welcome

This comment has been minimized.

Copy link

commented May 6, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@mrfelton

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Hi Max,

We do already support this to some degree. When running as a neutrino light client we always default to private channels and we include the routing hints in invoices that we create.

When connecting to a a remote node we make the assumption that your node is probably an always on node, more suitable as a routing candidate and that your channels are public. So in this instance we do not include the routing hints.

I think a good enhancement to this would be to give owners of remote nodes the ability to make this choice for themselves and override our assumptions about wether or not routing hints should be included when creating invoices.

@MaxHillebrand

This comment has been minimized.

Copy link
Author

commented May 6, 2019

Very nice, thanks Tom!

Yes, for BIP158 SPV nodes it probably makes sense to have private channels.
And I agree that it would be nice to have a optional checkbox for remote node users. At least when there is one private channel opened.

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue May 11, 2019

feat(wallet): ability to include invoice routing hints
Add the ability for remote node operators to specify wether or not
routing hints should be included in invoices. This enables users of
remote nodes to better operate over private channels.

Fix LN-Zap#2165

@mrfelton mrfelton self-assigned this May 11, 2019

@mrfelton mrfelton added this to the v0.5.0-beta milestone May 11, 2019

@mrfelton

This comment has been minimized.

Copy link
Member

commented May 11, 2019

@MaxHillebrand I've done an implementation of this in #2191

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue May 16, 2019

feat(wallet): ability to include invoice routing hints
Add the ability for remote node operators to specify wether or not
routing hints should be included in invoices. This enables users of
remote nodes to better operate over private channels.

Fix LN-Zap#2165

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue May 16, 2019

feat(wallet): ability to include invoice routing hints
Add the ability for remote node operators to specify wether or not
routing hints should be included in invoices. This enables users of
remote nodes to better operate over private channels.

Fix LN-Zap#2165
@mrfelton

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Closed via #2191

@mrfelton mrfelton closed this May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.