Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 lnconnect string not displayed correctly #2172

Closed
sohomang opened this issue May 8, 2019 · 3 comments

Comments

@sohomang
Copy link

commented May 8, 2019

Description

While connecting for the first time to a node, trying to use a connection string that contains an IPv6 address cuts it on the UI.

Expected Behavior

The host address and port should be displayed in its full form (e.g. "[2a01:e34:vru2:8351:1334:c421:23a2:vab9]:10009").

Actual Behavior

Only the part preceding the ":" character is displayed: "[2a01" (see screenshot below).

Possible Fix

Don't cut the IP string to the first ":" char.

Possible additional issue

If the code in charge of decomposing the connection string actually stops at the first ":" char, it could be impossible for people on IPv6-only networks to connect to their nodes. I haven't checked if that's the cas though, as I only have IPv4.

Your Environment

  • Zap version: 0.4.1-beta
  • Operating System and version: macOS Mojave 10.14.4

Screenshot 2019-05-08 at 02 33 11

@welcome

This comment has been minimized.

Copy link

commented May 8, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@sohomang sohomang changed the title IPv6 lnconnect string not supported IPv6 lnconnect string not displayed correctly May 8, 2019

@mrfelton

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Thanks for the report @sohomangue .

The host string is only truncated for display purposes. The intention is to remove the port part so that we displaying the info that the user most cares about - what host they are connecting to. When we initiate the connection we use the full host/port string.

We will look to fix this so that the display better handles IPv6.

@mrfelton mrfelton added this to the v0.5.0-beta milestone May 16, 2019

@korhaliv korhaliv self-assigned this May 24, 2019

korhaliv added a commit to korhaliv/zap-desktop that referenced this issue May 24, 2019

korhaliv added a commit to korhaliv/zap-desktop that referenced this issue May 27, 2019

korhaliv added a commit to korhaliv/zap-desktop that referenced this issue May 27, 2019

korhaliv added a commit to korhaliv/zap-desktop that referenced this issue May 27, 2019

korhaliv added a commit to korhaliv/zap-desktop that referenced this issue May 27, 2019

@mrfelton

This comment has been minimized.

Copy link
Member

commented May 27, 2019

Closed via #2287

@mrfelton mrfelton closed this May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.