Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction ID copy functionality #2186

Closed
maraph opened this issue May 10, 2019 · 3 comments

Comments

@maraph
Copy link

commented May 10, 2019

The transaction view doesn't allow to copy the transaction ID.

Detailed Description

When going to the detail view of a transaction, one is presented with a link to https://blockstream.info when clicking on the transaction ID.
There should be an easy and convenient possibility to copy the presented ID.

2019-05-10 14_13_53-Window

Context

  • Not everyone wants to track his or her transaction through https://blockstream.info.
  • Not everyone wants to use his default browser to open the transaction info, as this could lead to privacy issues, if the default browser is not private/secure.

Possible Implementation

  1. Add a small copy symbol near the link
  2. Show the full transaction ID and make it easy to copy (like in a code block)

Your Environment

  • Zap version: 0.4.1-beta
  • Operating System and version: Windows 10
@welcome

This comment has been minimized.

Copy link

commented May 10, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@maraph

This comment has been minimized.

Copy link
Author

commented May 10, 2019

On a sidenote, the link to the contributing guidelines is invalid: https://github.com/LN-Zap/zap-desktop/blob/master/CONTRIBUTING.md

@mrfelton mrfelton self-assigned this Jun 13, 2019

@mrfelton mrfelton added this to the v0.5.0-beta milestone Jun 13, 2019

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Jun 13, 2019

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Jun 13, 2019

@mrfelton

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

Closed via #2420

@mrfelton mrfelton closed this Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.