Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce frequency of updates to node data #2225

Closed
mrfelton opened this issue May 16, 2019 · 1 comment

Comments

2 participants
@mrfelton
Copy link
Member

commented May 16, 2019

Detailed Description

The UPDATE_NODE_DATA action gets called a lot in quick succession after creating a new wallet. We call this every time receive an update from the channel graph subscription with updated node data.

Context

excessive calls to UPDATE_NODE_DATA noticed in console after new wallet creation.

Possible Implementation

We should batch/throttle these in order to prevent excessive re-renders.

@mrfelton mrfelton added this to the v0.5.0-beta milestone May 16, 2019

@mrfelton mrfelton self-assigned this May 17, 2019

@mrfelton mrfelton removed their assignment May 27, 2019

@korhaliv korhaliv self-assigned this Jun 6, 2019

korhaliv added a commit to korhaliv/zap-desktop that referenced this issue Jun 11, 2019

korhaliv added a commit to korhaliv/zap-desktop that referenced this issue Jun 11, 2019

@korhaliv korhaliv referenced this issue Jun 11, 2019

Merged

perf: debounce updateNodeData #2399

4 of 6 tasks complete

korhaliv added a commit to korhaliv/zap-desktop that referenced this issue Jun 11, 2019

korhaliv added a commit to korhaliv/zap-desktop that referenced this issue Jun 11, 2019

korhaliv added a commit to korhaliv/zap-desktop that referenced this issue Jun 12, 2019

@mrfelton

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

Closed via #2399

@mrfelton mrfelton closed this Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.