Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel graph subscription sometimes fails to get setup after local wallet sync completion #2226

Closed
mrfelton opened this issue May 16, 2019 · 1 comment

Comments

1 participant
@mrfelton
Copy link
Member

commented May 16, 2019

Detailed Description

Sometimes we fail to set up the channel graph subscription after logging into a local wallet with the following error in the console:

zap:grpc [ERR]  CHANNELGRAPH ERROR: Error: router not started
    at Http2CallStream.call.on (call.js?4dae:68)
    at Http2CallStream.emit (events.js:187)
    at Http2CallStream.endCall (call-stream.js?85fb:74)
    at handlingTrailers (call-stream.js?85fb:163)
    at process._tickCallback (internal/process/next_tick.js:68) +3ms

This is an issue since updating to 0.6.1-beta-rc1-1-g83adaaa0. Steps were taken already to try to resolve this by waiting until the sy8nced_to_chain flag has flipped to true before trying to set up the subscription. However, this doesn't seem to be enough as there is no guarantee that the lnd router has been started at that point.

Context

Logging in to a local wallet

Possible Implementation

Basic fix
Add delay between sync_to_chain detection and setting up channel graph subscription.

Better fix
If the subscription fails to get set up, keep automatically retrying, ideally on some kind of backoff schedule.

@mrfelton mrfelton added this to the v0.5.0-beta milestone May 16, 2019

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue May 17, 2019

fix(grpc): setup channel graph subscription after
If we fail to subscribe to the channel graph after initial sync has
completed, keep retrying until we get a successful connection.

Fix LN-Zap#2226

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue May 17, 2019

fix(grpc): setup channel graph stream after sync
If we fail to subscribe to the channel graph after initial sync has
completed keep retrying until we get a successful connection.

Fix LN-Zap#2226

@mrfelton mrfelton self-assigned this May 17, 2019

@mrfelton

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

Closed via #2235

@mrfelton mrfelton closed this May 21, 2019

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue May 21, 2019

fix(grpc): setup channel graph stream after sync
If we fail to subscribe to the channel graph after initial sync has
completed keep retrying until we get a successful connection.

Fix LN-Zap#2226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.