Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't increment satoshi amount using keyboard up arrow key #2679

Closed
bolatovumar opened this issue Aug 2, 2019 · 1 comment · Fixed by #2686

Comments

@bolatovumar
Copy link
Contributor

commented Aug 2, 2019

This is a tiny issue but I noticed one can't increment the satoshi amount using keyboard up arrow key when in "Send Bitcoin" screen.

Screen Shot 2019-08-02 at 6 45 14 PM

Expected Behavior

Can increment the satoshi amount using keyboard up arrow key.

Actual Behavior

Can't increment the satoshi amount using keyboard up arrow key.
Bits and BTC amount, however, can be incremented using keyboard up arrow key.

Possible Fix

CryptoAmountInput.js on line 66 has a step property set to 0.00000001 which is used to increment the amount in the input field. For sats this should be set to 1.

Another possible fix could be to disable the increment/decrement functionality using the keyboard up/down arrow keys.

Steps to Reproduce

  1. Click on 'Pay' button in the main UI
  2. Input a valid address into the address field
  3. Focus your input to the amount field and switch the denomination to satoshis
  4. Attempt to continually increment the value of the field using the up arrow key
  5. Notice that the value can not be incremented

The above works fine in case of BTC or Bits values.

Your Environment

  • Zap version: 0.5.2-beta and 0.6.0-alpha
@bolatovumar

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

Another related but separate issue is that the up/down arrow icons in the amount field are tiny and hard to click on if the user chooses to do so. It might make sense to hide them if we don't really care about this bit or make the icons larger if we want to keep them.

@mrfelton mrfelton self-assigned this Aug 5, 2019
@mrfelton mrfelton added this to the v0.5.3-beta milestone Aug 5, 2019
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.