Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping drop shadows creating a very "dark" look in light theme #2680

Closed
bolatovumar opened this issue Aug 2, 2019 · 0 comments · Fixed by #2689

Comments

@bolatovumar
Copy link
Contributor

commented Aug 2, 2019

This is not a behavior bug but a visual issue in light theme. This is not an issue in dark theme.

Description

Drop shadows applied to the header and the "Search activity" input field overlap creating a very "dark" look where I would expect to see something more light and airy. Both drop shadows are quite large (24px) and dark causing this issue as they start overlapping causing an even darker look.

Possible Fix

Make both drop shadows smaller and less dark. I applied this box shadow property value to header: 0 2px 12px 0 rgba(0,0,0,0.25) and this value to the search bar: 0 2px 12px 0 rgba(0,0,0,.1) to get the look in the below screenshot:

Screen Shot 2019-08-02 at 7 46 25 PM

Contrast it with the current look:
Screen Shot 2019-08-02 at 7 50 12 PM

Steps to Reproduce

  1. Take a look at the area between the header and the "Search activity" input field and notice how dark this area is in light theme.

Your Environment

  • Zap version: 0.6.0-alpha
@mrfelton mrfelton self-assigned this Aug 5, 2019
@mrfelton mrfelton added this to the v0.5.3-beta milestone Aug 5, 2019
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Aug 5, 2019
@mrfelton mrfelton referenced this issue Aug 5, 2019
4 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.