Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel close dialog csvDelay prop is marked as required but is not always passed in #2692

Closed
bolatovumar opened this issue Aug 6, 2019 · 0 comments

Comments

@bolatovumar
Copy link
Contributor

commented Aug 6, 2019

csvDelay prop is marked is required ChannelCloseDialog component but sometimes undefined is passed in causing an error.

Description

Not much else to say here and it's an insignificant issue which can be addressed very easily.

Possible Fix

Either mark csvDelay as not required or ensure it's always passed in. The underlying issue in my case is on line 14 of /containers/ChannelCloseDialog.js where it's assumed that the selectedChannel always has a csv_delay property but it doesn't always have it.

Link to container component: https://github.com/LN-Zap/zap-desktop/blob/master/renderer/containers/Channels/ChannelCloseDialog.js#L14

Link to component which throws the error: https://github.com/LN-Zap/zap-desktop/blob/master/renderer/components/Channels/ChannelCloseDialog.js#L79

Steps to Reproduce

  1. Open a channel with a node so it's in "pending open" state (I opened a channel with a node with this id: 023a8dfe081c6bbd0504e599f33d39d17687de63023a8b20afcb59147d9d77c19d)
  2. Click on the "More" button for this channel in the channel management UI.
  3. Notice the error in the console.

The above steps may not always work but worked in my case.

Your Environment

  • Zap version: 0.6.0-alpha
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.