Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code slightly mis-aligned on "Welcome" screen #2700

Closed
bolatovumar opened this issue Aug 7, 2019 · 0 comments · Fixed by #2724

Comments

@bolatovumar
Copy link
Contributor

commented Aug 7, 2019

This is terribly nit-picky and I am very sorry but I noticed this while creating a new wallet from scratch. The QR code under "Fund your wallet" on the "Welcome" screen is slightly misaligned to the top and left.

See screenshot below:
Screen Shot 2019-08-07 at 11 03 45 AM

See screenshot below to how it would look like if the QR code were centred perfectly:
Screen Shot 2019-08-07 at 11 05 00 AM

Possible Fix

This is easily fixable by applying this CSS to the QR code instead of using pixel-based absolute positioning:

position: absolute;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);

The above will perfectly center any element inside of another relatively positioned element.

Steps to Reproduce

  1. Start the "Create new wallet" process
  2. Get to to the "Welcome" screen
  3. Notice the QR code is slightly mis-aligned.

Your Environment

  • Zap version: 0.5.2-beta
bolatovumar added a commit to bolatovumar/zap-desktop that referenced this issue Aug 7, 2019
@mrfelton mrfelton added this to the v0.5.3-beta milestone Aug 8, 2019
bolatovumar added a commit to bolatovumar/zap-desktop that referenced this issue Aug 10, 2019
bolatovumar added a commit to bolatovumar/zap-desktop that referenced this issue Aug 10, 2019
bolatovumar added a commit to bolatovumar/zap-desktop that referenced this issue Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.