New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find & Replace improvements #127

Closed
ifokkema opened this Issue Sep 9, 2016 · 2 comments

Comments

Projects
2 participants
@ifokkema
Member

ifokkema commented Sep 9, 2016

After the first release of Find & Replace, some improvements are needed:

  • Run checkFields() on the data, to ensure correctness of the resulting string.
    • Really make sure this step can not be evaded.
    • Then, more columns can be allowed to be "editable" by F&R.
  • Numeric columns can now receive text characters, which results in empty fields.
    • Do allow some notation, though. Not sure if MySQL's way of checking what numeric corresponds to PHP's is_numeric().
  • When you select a column, then resubmit the VL, suddenly a tooltip for F&R options menu is shown. Perhaps this is meant to show directly after selecting a column?
  • Document Find and Replace.
  • Look at inc-lib-columns.php, see where functions are used, and decide on what to do with that file.

@ifokkema ifokkema removed this from TODO in Milestone 3.0-19 Jun 14, 2017

@ifokkema ifokkema added this to TODO in Milestone 3.0-20 Jun 14, 2017

@mkroon1 mkroon1 removed this from TODO in Milestone 3.0-20 Oct 5, 2017

@mkroon1 mkroon1 added this to Todo in Milestone 3.0-21 Oct 5, 2017

@mkroon1 mkroon1 added this to the 3.0 Build 21 milestone Oct 5, 2017

@mkroon1 mkroon1 moved this from Todo to In progress in Milestone 3.0-21 Nov 10, 2017

@mkroon1

This comment has been minimized.

Collaborator

mkroon1 commented Nov 10, 2017

Non-numeric values for numeric columns should be caught by checkFields(). I don't think an extra check in MySQL is needed there.

When you select a column, then resubmit the VL, suddenly a tooltip for F&R options menu is shown. Perhaps this is meant to show directly after selecting a column?

Currently unable to reproduce this issue on both Chrome and Firefox. Perhaps the issue was resolved inadvertently.

@mkroon1 mkroon1 moved this from In progress to To be reviewed in Milestone 3.0-21 Dec 6, 2017

@ifokkema

This comment has been minimized.

Member

ifokkema commented Jan 26, 2018

Thanks, both problems seems to have been solved indeed!

I found some other issues, but have corrected them. I will go through it again just to be sure, but probably it's OK like this 😄

Milestone 3.0-21 automation moved this from To be reviewed to Done Jan 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment